Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain rejected candidates #17

Merged
merged 7 commits into from
Aug 5, 2019
Merged

Conversation

TSchiefer
Copy link
Member

  • enum_pk_candidates(), cdm_enum_pk_candidates() and cdm_enum_fk_candidates() explain now rejections in a new column why (admittedly rather superficially)

(could be more detailed (e.g. class differs etc.), but I don't see why it would need to be, since this explanation is just as correct)
@TSchiefer TSchiefer requested a review from krlmlr July 26, 2019 09:23
@TSchiefer
Copy link
Member Author

(BTW, just wondering if "list" wouldn't be nicer than "enum" )

@TSchiefer
Copy link
Member Author

TSchiefer commented Jul 26, 2019

Fixes #12

@krlmlr krlmlr merged commit 07805d8 into master Aug 5, 2019
@krlmlr krlmlr deleted the f-explain-rejected-candidates branch August 5, 2019 20:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants