Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New table_names argument to cdm_copy_to() #79

Merged
merged 10 commits into from
Oct 8, 2019
Merged

New table_names argument to cdm_copy_to() #79

merged 10 commits into from
Oct 8, 2019

Conversation

krlmlr
Copy link
Collaborator

@krlmlr krlmlr commented Oct 1, 2019

@TSchiefer: Can you please pick up from here?

  • Document argument, note that all table names are quoted with dbplyr::ident_q()
  • Add tests

@TSchiefer TSchiefer mentioned this pull request Oct 1, 2019
Closed
krlmlr
krlmlr commented Oct 8, 2019
View reviewed changes
Copy link
Collaborator Author

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll tweak.

R/db-interface.R Outdated Show resolved Hide resolved
R/db-interface.R Outdated Show resolved Hide resolved
R/error-helpers.R Outdated Show resolved Hide resolved
R/error-helpers.R Outdated Show resolved Hide resolved
R/error-helpers.R Outdated Show resolved Hide resolved
@krlmlr krlmlr changed the title WIP: New table_names argument to cdm_copy_to() New table_names argument to cdm_copy_to() Oct 8, 2019
@krlmlr krlmlr merged commit fb45241 into master Oct 8, 2019
@krlmlr krlmlr deleted the f-copy-to-rename branch October 8, 2019 06:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @TSchiefer