Add pitch #128
Add pitch #128
Conversation
README.Rmd
Outdated
| * If your package... | ||
|
|
||
| * is brand-new, remember to run `fledge::bump_version()` regularly. | ||
| * has already undergone some development, not too late to jump on the train! Run `fledge::bump_version()` and then `fledge::tag_version()`. |
There was a problem hiding this comment.
mmh actually does one really need fledge::tag_version() at this stage? actually no since it's called by bump_version() via finalize_version()? @krlmlr
There was a problem hiding this comment.
tag_version() is called by finalize_version() . Can we showcase "jumping on the train" in the demo vignette?
| @@ -0,0 +1,79 @@ | |||
| --- | |||
| title: "Fledge internals" | |||
There was a problem hiding this comment.
these are not really internals though. I was putting this outside of the main vignette as it might be too detailed? 🤔
There was a problem hiding this comment.
Most users will only need bump_version() and finalize_version() . Should we account for that in the reference index and in the table?
|
I explored the pkgdown failure 🕵️♀️ https://github.com/r-lib/pkgdown/issues/1797 -- but why is the pkgdown workflow using pkgdown dev version? |
This comment has been minimized.
This comment has been minimized.
|
I enjoy walking the bleeding edge with pkgdown. |
|
Can you please push to a branch that starts with |
| @@ -0,0 +1,79 @@ | |||
| --- | |||
| title: "Fledge internals" | |||
There was a problem hiding this comment.
Most users will only need bump_version() and finalize_version() . Should we account for that in the reference index and in the table?
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
|
@krlmlr a few remaining items
You mean most users won't do CRAN (or Bioconductor etc) releases?
|
|
Thanks! (Once I can get it to render, that is.) |
|
@krlmlr except it can't be rendered with pkgdown dev version 😭 |
Fix #106
Fix #105
Fix #104
Fix #115
Fix #32
Fix #123
Fix #114
Fix #127
TODOS