More tests, quietly #168
Merged
More tests, quietly #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelle
commented
Dec 2, 2021
maelle
commented
Dec 2, 2021
- `tag_version(force = FALSE)` succeeds when the tag exists and points to the head commit (#167).
maelle
commented
Dec 6, 2021
| @@ -24,7 +27,10 @@ collect_news <- function(messages) { | |||
| } | |||
| } | |||
|
|
|||
| cli_alert_success("Found {.field {length(message_items)}} NEWS-worthy entries.") | |||
| if (fledge_chatty()) { | |||
| cli_alert_success("Found {.field {length(message_items)}} NEWS-worthy entries.") | |||
There was a problem hiding this comment.
btw I tried wrapping cli_alert() into another function but it was a mess because of the glue-like stuff in cli_alert() so it was simpler to use the conditional.
krlmlr
reviewed
Dec 6, 2021
|
I need to fix some tests actually 😅 |
|
such interesting failures 🙄 old[38:50] vs new[44:62]
" bump_version()"
"Message <cliMessage>"
" > Scraping 4 commit messages."
" v Found 2 NEWS-worthy entries."
+ " "
" -- Updating NEWS --"
+ " "
" > Adding new entries to 'NEWS.md'."
+ " "
" -- Update Version --"
+ " "
" v Package version bumped to 0.0.0.9001."
" > Adding header to 'NEWS.md'."
" > Committing changes."
+ " "
" -- Tagging Version --"
+ " "
" > Creating tag v0.0.0.9001 with tag message derived from 'NEWS.md'."
" ! Call `fledge::finalize_version()`."
"Output"
i.e. empty lines. |
|
@krlmlr the failure on Windows because Windows runs testthat 3.1.0 not testthat 3.1.1 😅 |
|
@krlmlr as this PR removes the empty lines it'd fix the problems on main. For reference r-lib/testthat#1509 |
|
Thanks! Let's deal with the problems in |
what problems? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #117
Fix #5
Fix #167