Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking center of ColorWheel returns mid range grey instead of white #2

Closed
cyotek opened this issue Dec 3, 2013 · 4 comments
Closed
Assignees
Labels

Comments

@cyotek
Copy link
Owner

cyotek commented Dec 3, 2013

I think there is a problem with the color selection, it does not match the actual selected color try to select the white in the middle of the color wheel. In other words, you will get a gray 127, 127, 127 instead of white 255, 255, 255.

Good luck,
Faisal

@cyotek
Copy link
Owner Author

cyotek commented Dec 3, 2013

This is because the SetColor gets a HSL color based on the angle (hue) and saturation. There's no luminance available though so it uses a default of .5, which gives you that middle grey. Change it to 1 and you'll get white... wherever you click in the wheel. Not quite as useful, I think you'll agree!

Not sure on how to fix this one to be honest. I'll have a think.

Regards;
Richard Moss

@ghost ghost assigned cyotek Dec 3, 2013
@cyotek
Copy link
Owner Author

cyotek commented Jan 12, 2014

Fixed the bug where the LightnessColorSlider control couldn't be linked to a ColorWheel via the ColorEditorManager and have the values update as expected. Closing this issue now as you can link them up, then use the Color property of the ColorEditorManager to get a composite value.

@cyotek cyotek closed this as completed Jan 12, 2014
@faisalr
Copy link

faisalr commented Jan 13, 2014

By the way I think it's not a hack it's the way HSL works.

Try using HSV (HSB) with value 1 instead of .5

Regards,
Faisal

@cyotek
Copy link
Owner Author

cyotek commented Jan 13, 2014

Hello... I have no idea what you're referring to in regards to a hack.

As I've already mentioned, if you use a value of 1 you get a white wheel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants