Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPD]composer.json: composer create-project installing older version #943

Merged
merged 1 commit into from
Apr 19, 2024
Merged

[UPD]composer.json: composer create-project installing older version #943

merged 1 commit into from
Apr 19, 2024

Conversation

christer77
Copy link
Member

@christer77 christer77 force-pushed the composer-create-project-installing-older-version branch from af7ff27 to f119681 Compare April 10, 2024 14:07
Shadow243
Shadow243 requested changes Apr 13, 2024
View reviewed changes
Copy link
Member

@Shadow243 Shadow243 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually see version 4.17 with bug fixes and some good reactions. Seems like they're making steady improvements of version 4.16.

https://github.com/ezyang/htmlpurifier/releases

@marclaporte
Copy link
Member

@Shadow243 Since composer.json has "ezyang/htmlpurifier": "^4.16", it should get 4.17, 4.18, etc. right?

@marclaporte
Copy link
Member

Yes, we are already getting: https://github.com/cypht-org/cypht/blob/master/composer.lock#L249

@christer77 I don''t understand how this MR fixes the issue

@christer77 christer77 mentioned this pull request Apr 15, 2024
Closed
Shadow243
Shadow243 reviewed Apr 16, 2024
View reviewed changes
composer.json Outdated
@@ -32,7 +32,7 @@
"ext-mbstring": "*",
"ext-openssl": "*",
"ext-session": "*",
"ezyang/htmlpurifier": "^4.13",
"ezyang/htmlpurifier": "^4.16",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christer77 Can you add composer.lock to this PR please!

@christer77 christer77 force-pushed the composer-create-project-installing-older-version branch from f119681 to a68a01c Compare April 16, 2024 23:31
marclaporte
marclaporte reviewed Apr 17, 2024
View reviewed changes
composer.lock Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ezyang/htmlpurifier doesn't change in composer.lock

@christer77 christer77 force-pushed the composer-create-project-installing-older-version branch from a68a01c to 4d2cdfc Compare April 18, 2024 06:04
@marclaporte marclaporte merged commit 080c8ab into cypht-org:master Apr 19, 2024
@marclaporte
Copy link
Member

@christer77 I merged this because it leads to updating composer.lock so we get latest dependencies, but your change of ezyang/htmlpurifier in composer.json had no impact on composer.lock

ezyang/htmlpurifier ^4.13 means 4.13 or higher.
https://getcomposer.org/doc/articles/versions.md#caret-version-range-

So if this MR fixes the intended bug, it comes from another dependency.

@christer77 christer77 mentioned this pull request Apr 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadow243 Shadow243 Shadow243 requested changes

@marclaporte marclaporte marclaporte left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christer77 @marclaporte @Shadow243