Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add option to disable command log #8689

Merged
merged 4 commits into from
Sep 30, 2020

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Sep 29, 2020

TR-361

Add env var for debugging performance issues related to command log rendering

  • Closes N/A

User facing changelog

misc: added environment variable CYPRESS_NO_COMMAND_LOG for disabling the rendering of the Command Log.

Additional details

How has the user experience changed?

PR Tasks

  • add tests
  • remove circle.yml changes
  • Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 29, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Sep 30, 2020



Test summary

8567 0 124 3


Run details

Project cypress
Status Passed
Commit f33f8ba
Started Sep 30, 2020 10:11 PM
Ended Sep 30, 2020 10:23 PM
Duration 12:03 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kuceb kuceb changed the title fix: add option to disable command log chore: add option to disable command log Sep 30, 2020
@kuceb kuceb marked this pull request as ready for review September 30, 2020 19:14
@flotwig
Copy link
Contributor

flotwig commented Sep 30, 2020

any reason why not CYPRESS_NO_COMMAND_LOG instead of CYPRESS_NO_COMMANDLOG? the lack of space seems arbitrary

@kuceb
Copy link
Contributor Author

kuceb commented Sep 30, 2020

@flotwig it's arbitrary. I'll change it

@flotwig
Copy link
Contributor

flotwig commented Sep 30, 2020

It's simply so beautiful
image

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think @bkucera should you add a section to the troubleshooting doc for this? or, what is the documentation plan?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 14, 2020

Released in 5.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants