minimum viewport size for desktop-gui needs to be increased

[jennifer-shehane]

The nav overlaps with the project name displaying in lefthand corner.

I think this can be fixed in the packages/desktop-gui css, but we could also set a minWidth on the window itself here https://github.com/cypress-io/cypress/blob/code-of-conduct/packages/server/lib/gui/windows.coffee#L129

[brian-mann]

Needs to be done in the `server` code (not in CSS).

…

On Fri, Nov 3, 2017 at 2:19 PM, Jennifer Shehane ***@***.***> wrote: The nav overlaps with the project name displaying in lefthand corner. [image: screen shot 2017-11-03 at 2 11 42 pm] <https://user-images.githubusercontent.com/1271364/32389467-10aab080-c0a1-11e7-838d-8844b71758c7.png> I think this can be fixed in the packages/desktop-gui css, but we could also set a minWidth on the window itself here https://github.com/cypress-io/cypress/blob/code-of-conduct/ packages/server/lib/gui/windows.coffee#L129 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#869>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABNc8IWbrOuFP5tg4ABmG2hwB7S6HKOrks5sy1k-gaJpZM4QRfh0> .

[chrisbreiding]

Is increasing the minimum width the right solution? What if someone has a project name longer than cypress-example-kitchensink?

I think a better solution is to make the desktop-gui more responsive to width changes. Right now, there are too many hard-coded values for how tall certain elements are assumed to be. We could utilize flexbox to help with situations like this.

[jennifer-shehane]

^ that's why I mentioned css in desktop-gui at first. I'd have to look back at what we're doing for the nav to remember, but most definitely flexbox is a good solution here.

[jennifer-shehane]

• Nav view: https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/src/app/nav.jsx
• Nav css: https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/src/app/nav.scss
• Nav test: https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/cypress/integration/nav_spec.coffee#L1

[cypress-bot]

The code for this is done in cypress-io/cypress#4737, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 3.4.1.