electron: upgrade to 1.8.2, node 8.2.1, chromium 59 #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤗
…Sent from my iPhone
On Feb 7, 2018, at 18:43, Brian Mann ***@***.***> wrote:
You can view, comment on, or merge this pull request online at:
#1275
Commit Summary
electron: upgrade to 1.8.2, node 8.2.1, chromium 59
File Changes
M .node-version (2)
M package.json (2)
M packages/electron/package.json (2)
M packages/server/__snapshots__/run_plugins_spec.coffee (5)
M packages/server/test/integration/http_requests_spec.coffee (2)
Patch Links:
https://github.com/cypress-io/cypress/pull/1275.patch
https://github.com/cypress-io/cypress/pull/1275.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
- node-sass 3.13.1 does not work with Node 8, since we’re upgrading the project to node 8.2.1, we needed node-sass 4.5.3+. This node-sass dep was coming from gulp-sass dep in zunder which has since been updated
|
Just as a note, I get this error in the console when building with this version update:
This is a bug in Chromium and seems to be ok to safely ignore. |
saadaouad
reviewed
Feb 8, 2018
| @@ -1 +1 @@ | |||
| 6.5.0 | |||
| 8.2.1 | |||
There was a problem hiding this comment.
Why not use the latest stable version 8.9?
|
To match the node version included in the electron version
…Sent from my iPhone
On Feb 8, 2018, at 18:32, Saad Aouad ***@***.***> wrote:
@saadaouad commented on this pull request.
In .node-version:
> @@ -1 +1 @@
-6.5.0
+8.2.1
Why not use the latest stable version 8.9?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This was referenced Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.