Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename domain_fn to origin_fn #21413

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

AtofStryker
Copy link
Contributor

  • Closes N/A

User facing changelog

Additional details

Missed a change that was supposed to be a part of #21231. Small naming fix

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 9, 2022

Thanks for taking the time to open a PR!

@AtofStryker AtofStryker changed the title rename domain_fn to origin_fn chore: rename domain_fn to origin_fn May 9, 2022
@AtofStryker AtofStryker marked this pull request as ready for review May 9, 2022 19:58
@AtofStryker AtofStryker requested a review from a team as a code owner May 9, 2022 19:58
@AtofStryker AtofStryker self-assigned this May 9, 2022
@AtofStryker AtofStryker added the topic: cy.origin Problems or enhancements related to cy.origin command label May 9, 2022
@cypress
Copy link

cypress bot commented May 9, 2022



Test summary

4437 0 51 0Flakiness 0


Run details

Project cypress
Status Passed
Commit bd4f744
Started May 9, 2022 8:41 PM
Ended May 9, 2022 8:53 PM
Duration 12:21 💡
OS Linux Debian - 10.10
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mjhenkes mjhenkes added this to the 11.0 milestone May 9, 2022
@AtofStryker AtofStryker merged commit b66df64 into develop May 9, 2022
@AtofStryker AtofStryker deleted the chore/clean-up-domain-refs branch May 9, 2022 22:13
tgriesser added a commit that referenced this pull request May 13, 2022
* 10.0-release: (22 commits)
  fix: migrate multiples projects when in global mode (#21458)
  test: fix flaky cy-in-cy selector validity test (#21360)
  chore: remove unused codeGenGlobs (#21438)
  fix: use correct path for scaffolding spec on CT (#21411)
  fix: remove breaking options from testing type on migration (#21437)
  fix: test-recording instructions in Component Test mode (#21422)
  feat: distinguish app vs launchpad utm_source when using utm params (#21424)
  chore: update stubbed cloud types (#21451)
  chore: change to yarn registry
  fix(sessions): refactor flows, fix grouping bugs and align validation fail text (#21379)
  chore(sessions): more driver tests (#21378)
  chore: rename domain_fn to origin_fn (#21413)
  chore: release 9.6.1 (#21404)
  fix: ensure that proxy logs are updated after the xhr has actually completed (#21373)
  chore: Re-organize tests in assertions_spec.js (#21283)
  chore: Distribute tests to desktop-gui containers. Make `desktop-gui` tests faster! (#21305)
  chore(sessions): add additional tests (#21338)
  fix: Allow submit button to be outside of the form for implicit submission (#21279)
  fix(launcher): support Firefox as a snap (#21328)
  chore(sessions): break out sessions manager code and add unit tests (#21268)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cy.origin Problems or enhancements related to cy.origin command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants