fix(launcher): support Firefox as a snap #21328
Conversation
|
Thanks for taking the time to open a PR!
|
This reverts commit 9a38223.
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
flotwig
requested review from
jennifer-shehane and
BlueWinds
and removed request for
a team and
jennifer-shehane
|
|
||
| await fd.close() | ||
|
|
||
| return buffer.slice(0, bytesRead).toString('utf8').includes('exec /snap/bin/firefox') |
There was a problem hiding this comment.
Today I learned about reading only the opening bytes of a file! This seemed odd (particularly the slice), so I poked around the docs and command line, and lo, you have done it correctly. :)
|
|
||
| async function isFirefoxSnap (binary: string): Promise<boolean> { | ||
| try { | ||
| return await Bluebird.resolve((async () => { |
There was a problem hiding this comment.
I'd like to avoid Bluebird promises in newly written code when possible. Especially since we're already inside an async function, do we need Bluebird.resolve here?
There was a problem hiding this comment.
I'm using Bluebird.resolve to get access to .timeout. I could Promise.race/new Promise/setTimeout but I figure that unless we are planning on moving all the code in the code base to not use Bluebird, might as well use the utilities we have. I also generally agree that BB should be avoided in new code.
There was a problem hiding this comment.
That is something I would like to do at some point, remove bluebird from our existing code. But adding timeout utility functions is beyond the scope of this PR, fair enough.
| const binaryPath = await which(binary) | ||
|
|
||
| // if the bin path or what it's symlinked to start with `/snap/bin`, it's a snap | ||
| if (binaryPath.startsWith('/snap/bin/') || (await fs.realpath(binaryPath)).startsWith('/snap/bin')) return true |
* 10.0-release: (22 commits) fix: migrate multiples projects when in global mode (#21458) test: fix flaky cy-in-cy selector validity test (#21360) chore: remove unused codeGenGlobs (#21438) fix: use correct path for scaffolding spec on CT (#21411) fix: remove breaking options from testing type on migration (#21437) fix: test-recording instructions in Component Test mode (#21422) feat: distinguish app vs launchpad utm_source when using utm params (#21424) chore: update stubbed cloud types (#21451) chore: change to yarn registry fix(sessions): refactor flows, fix grouping bugs and align validation fail text (#21379) chore(sessions): more driver tests (#21378) chore: rename domain_fn to origin_fn (#21413) chore: release 9.6.1 (#21404) fix: ensure that proxy logs are updated after the xhr has actually completed (#21373) chore: Re-organize tests in assertions_spec.js (#21283) chore: Distribute tests to desktop-gui containers. Make `desktop-gui` tests faster! (#21305) chore(sessions): add additional tests (#21338) fix: Allow submit button to be outside of the form for implicit submission (#21279) fix(launcher): support Firefox as a snap (#21328) chore(sessions): break out sessions manager code and add unit tests (#21268) ...
|
The snap version of firefox and chromium are not detected by cypress for 12.17.2, testing on Ubuntu 22.04 and newer |
|
@nicktelindertvmw Please open a new issue describing the behavior and a reproducible example |
User facing changelog
Additional details
snapversion of Chromium is installed #7020Had to change@types/nodeto the correct version to use thefsfeatures.@types/node#21329How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?