Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate multiples projects when in global mode #21458

Conversation

estrada9166
Copy link
Member

User facing changelog

Migrate multiples projects in global mode, we were setting the value for modeOptions.configFile everytime that we were making a migration, and this file was used as well to identify if we should make a migration - this should only be overridden when the value is set when starting the launchpad with the config file flag, that can only happen to launch a project and not in global mode.

Prevent setting the value, if it do not exist before, then there's no need to override the value

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 12, 2022

Thanks for taking the time to open a PR!

@estrada9166 estrada9166 marked this pull request as ready for review May 12, 2022 22:23
@estrada9166 estrada9166 requested review from lmiller1990 and ryanthemanuel and removed request for tgriesser May 12, 2022 22:23
@lmiller1990 lmiller1990 removed the request for review from ryanthemanuel May 13, 2022 02:48
@lmiller1990 lmiller1990 merged commit dcb4a61 into 10.0-release May 13, 2022
@lmiller1990 lmiller1990 deleted the alejandro/fix/migrate-multiple-projects-on-global-mode branch May 13, 2022 02:48
tgriesser added a commit that referenced this pull request May 13, 2022
* 10.0-release: (22 commits)
  fix: migrate multiples projects when in global mode (#21458)
  test: fix flaky cy-in-cy selector validity test (#21360)
  chore: remove unused codeGenGlobs (#21438)
  fix: use correct path for scaffolding spec on CT (#21411)
  fix: remove breaking options from testing type on migration (#21437)
  fix: test-recording instructions in Component Test mode (#21422)
  feat: distinguish app vs launchpad utm_source when using utm params (#21424)
  chore: update stubbed cloud types (#21451)
  chore: change to yarn registry
  fix(sessions): refactor flows, fix grouping bugs and align validation fail text (#21379)
  chore(sessions): more driver tests (#21378)
  chore: rename domain_fn to origin_fn (#21413)
  chore: release 9.6.1 (#21404)
  fix: ensure that proxy logs are updated after the xhr has actually completed (#21373)
  chore: Re-organize tests in assertions_spec.js (#21283)
  chore: Distribute tests to desktop-gui containers. Make `desktop-gui` tests faster! (#21305)
  chore(sessions): add additional tests (#21338)
  fix: Allow submit button to be outside of the form for implicit submission (#21279)
  fix(launcher): support Firefox as a snap (#21328)
  chore(sessions): break out sessions manager code and add unit tests (#21268)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants