Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Re-organize tests in assertions_spec.js #21283

merged 2 commits into from May 6, 2022


Copy link

@sainthkh sainthkh commented May 2, 2022

User facing changelog

N/A. It's an internal house keeping. This PR re-organizes tests that are organized in the wrong way.

Additional details

  • Why was this change necessary? => Tests are organized in the wrong way.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => N/A

How has the user experience changed?


PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

Copy link

@cypress-bot cypress-bot bot commented May 2, 2022

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review May 3, 2022
@sainthkh sainthkh requested a review from as a code owner May 3, 2022
@sainthkh sainthkh requested review from jennifer-shehane (assigned from cypress-io/end-to-end) and removed request for May 3, 2022
@mjhenkes mjhenkes added the E2E-core label May 4, 2022
@jennifer-shehane jennifer-shehane removed their request for review May 5, 2022
@flotwig flotwig requested review from flotwig and tbiethman May 6, 2022
flotwig approved these changes May 6, 2022
@flotwig flotwig merged commit 331e541 into cypress-io:develop May 6, 2022
57 checks passed
tgriesser added a commit that referenced this issue May 13, 2022
* 10.0-release: (22 commits)
  fix: migrate multiples projects when in global mode (#21458)
  test: fix flaky cy-in-cy selector validity test (#21360)
  chore: remove unused codeGenGlobs (#21438)
  fix: use correct path for scaffolding spec on CT (#21411)
  fix: remove breaking options from testing type on migration (#21437)
  fix: test-recording instructions in Component Test mode (#21422)
  feat: distinguish app vs launchpad utm_source when using utm params (#21424)
  chore: update stubbed cloud types (#21451)
  chore: change to yarn registry
  fix(sessions): refactor flows, fix grouping bugs and align validation fail text (#21379)
  chore(sessions): more driver tests (#21378)
  chore: rename domain_fn to origin_fn (#21413)
  chore: release 9.6.1 (#21404)
  fix: ensure that proxy logs are updated after the xhr has actually completed (#21373)
  chore: Re-organize tests in assertions_spec.js (#21283)
  chore: Distribute tests to desktop-gui containers. Make `desktop-gui` tests faster! (#21305)
  chore(sessions): add additional tests (#21338)
  fix: Allow submit button to be outside of the form for implicit submission (#21279)
  fix(launcher): support Firefox as a snap (#21328)
  chore(sessions): break out sessions manager code and add unit tests (#21268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants