-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: selector playground copy full command #22097
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated selector playground copy & print behaviors work as expected in E2E and CT. Only question I have regards closing the loop on your "tooltip" comment in the Issue. Did Ryan decide it should be dropped?
@mike-plummer For the sake of getting this in I punted the tooltip. I reached out to design and if they want a tooltip I'll create an issue for it |
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried, tested and true! Nice job 🎉
User facing changelog
Selector Playground "copy to clipboard" now copies full command rather than just the selector
Additional details
In 9.x, the "copy to clipboard" button would copy the full command (method + selector). In 10.x, we were only copying the selector. This PR brings us back in to parity with 9.x, and also adds an active state to the playground activator when opened.
Steps to test
Open any Cypress project and click through to the selector playground. Hitting the "copy to clipboard" button would only copy the selector "body" and not "cy.get('body')" (same for contains).
How has the user experience changed?
Before:
Screen.Recording.2022-06-03.at.11.44.57.AM.mov
After:
Screen.Recording.2022-06-03.at.11.41.50.AM.mov
PR Tasks
cypress-documentation
?type definitions
?