Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Merge latest from develop #22223

Merged
merged 11 commits into from
Jun 9, 2022
Merged

chore: Merge latest from develop #22223

merged 11 commits into from
Jun 9, 2022

Conversation

mike-plummer
Copy link
Contributor

Update Muaz's branch with latest from develop

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

flotwig and others added 11 commits June 6, 2022 16:07
@flotwig
release 10.0.3 [skip ci]
e35b3b0
@ZachJW34
fix: selector playground copy full command (#22097)
e58ec7a
@lmiller1990
chore: do not ship source for app and launchpad in binary (#22033)
a264373
@AtofStryker
chore: update windows contributing guide to have users set default sh…
b24a77d 
…ell script to command prompt (#22149)
@estrada9166 @jennifer-shehane
feat: show better error message if testing type is not configured (#2…
e5c1f91 
…2000)

* feat: show better error message if testing type is not configured

* Add tests

* Update tests

* Fix some tests

* Fix some tests

* Fix test

* Fix tests

* Update packages/errors/src/errors.ts

Co-authored-by: Jennifer Shehane <jennifer@cypress.io>

* Update with code review

* Fix test

* Add on link

Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
@mike-plummer
fix: Make spec row clickable across entire width (#22105)
0298b97 
* fix: Make spec row clickable across entire width

* Move click-sensitive row action wrapper to surround entire row
* Add styles to highlight spec icon on hocus to match Figma
* Small text highlight style change to match Figma

* Add missing data-cy selector

* Add tests for row expansion behaviors

* Fix directory row styling issues
@github-actions @lmiller1990
chore: Update Chrome (stable) to 102.0.5005.61 and Chrome (beta) to 1…
f9d9d38 
…03.0.5060.33 (#21623)

Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com>
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
@sainthkh @mjhenkes
fix: Remove period in "learn more." button (#21935)
406a193 
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
@flotwig
chore: skip windows canary check (#22197)
fccce5d
@lmiller1990
fix: support ESM projects using TypeScript with ts-node/esm (#22118)
abd986a 
* fix: support ESM projects using TypeScript with ts-node/esm

* better error handling

* fix test

* indentation

* register ts-node via --require hook

* be less aggressive with erroring

* update fix system tests

* remove obsolete test

* handle case of not using typescript

* replicate 9.x behavior for legacy plugins w/ ts-node

* make test project valid and adjust tests accordingly

* use ts-node/esm transpile only

* dummy

* extract util function

* merge in refactor using projectFixtureDirectory

* fix test
@mike-plummer
Merge branch 'develop' into mikep/CLOUD-577-develop-merge
e85aeae
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 9, 2022

Thanks for taking the time to open a PR!

@mike-plummer mike-plummer changed the base branch from develop to muaz/CLOUD-577-spec-list-display-latest-runs June 9, 2022 15:20
@mike-plummer mike-plummer marked this pull request as ready for review June 9, 2022 15:22
@mike-plummer mike-plummer requested review from a team and tgriesser as code owners June 9, 2022 15:22
@cypress
Copy link

cypress bot commented Jun 9, 2022


Test summary

37552 • 1 • 454 • 0 • Flakiness 4

Run details
Project cypress
Status Failed
Commit e85aeae
Started Jun 9, 2022 3:25 PM
Ended Jun 9, 2022 3:42 PM
Duration 16:18 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️

Failures

cypress/e2e/commands/actions/click.cy.js 1 Failed
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth

Flakiness

commands/actions/click.cy.js 1 Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
e2e/origin/commands/actions.cy.ts 1 Flakiness
1 cy.origin actions > #consoleProps > .selectFile()
cypress/proxy-logging.cy.ts 2 Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
2 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@MuazOthman MuazOthman merged commit f26ea2d into muaz/CLOUD-577-spec-list-display-latest-runs Jun 9, 2022
@MuazOthman MuazOthman deleted the mikep/CLOUD-577-develop-merge branch June 9, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MuazOthman MuazOthman MuazOthman approved these changes

@tgriesser tgriesser Awaiting requested review from tgriesser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mike-plummer @MuazOthman @lmiller1990 @flotwig @ZachJW34 @AtofStryker @estrada9166 @sainthkh