Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade electron/fuses to resolve code signing issue #24785

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Nov 23, 2022

User facing changelog

n/a

Additional details

@electron/fuses version 1.6.0 has an issue on M1s where setting fuses on the binary screws up ad hoc code signing for local development. 1.6.1 fixes this issue.

Steps to test

Try and run the app from the monorepo on an M1.

How has the user experience changed?

n/a

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 23, 2022

Thanks for taking the time to open a PR!

@lmiller1990
Copy link
Contributor

It works, make sure you've got Rosetta installed but don't use it's emulation mode - it just needs to be present on your system.

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@cypress
Copy link

cypress bot commented Nov 23, 2022



Test summary

46528 1 4326 0Flakiness 19


Run details

Project cypress
Status Failed
Commit 88b42f0
Started Nov 23, 2022 2:29 AM
Ended Nov 23, 2022 2:47 AM
Duration 17:07 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

cypress/e2e/e2e/origin/user_agent_override.cy.ts Failed
1 user agent override > persists modified user agent after cy.go

Flakiness

cypress/e2e/e2e/origin/cookie_behavior.cy.ts Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
5 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
This comment includes only the first 5 flaky tests. See all 19 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ryanthemanuel ryanthemanuel merged commit 5928369 into develop Nov 23, 2022
@ryanthemanuel ryanthemanuel deleted the ryanm/fix/electron-fuses-code-signing branch November 23, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants