Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update packages/example deployment script and cleanup package/example #25091

Merged
merged 19 commits into from
Jan 27, 2023

Conversation

emilyrohrbough
Copy link
Member

Fixing deployment issues with packages/example, cleaning up dead code, auto-fix lint changes and updated README to reflect current usage.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 9, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 9, 2022

47 flaky tests on run #43525 ↗︎

0 26600 1274 0 Flakiness 47

Details:

Merge branch 'develop' into update-examples-deployment
Project: cypress Commit: 0d319b70ad
Status: Passed Duration: 18:18 💡
Started: Jan 27, 2023 5:24 PM Ended: Jan 27, 2023 5:43 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test
network stubbing > intercepting request > can delay and throttle a StaticResponse
Flakiness  e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test
cy.origin waiting > alias > waits for the route alias to have a response
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test
... > correctly returns currentRetry
... > correctly returns currentRetry
... > correctly returns currentRetry
Flakiness  create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test
... > runs generated spec Screenshot
Flakiness  specs_list_latest_runs.cy.ts • 2 flaky tests • app-e2e

View Output Video

Test
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Screenshot
App/Cloud Integration - Latest runs and Average duration > when offline > shows offline alert then hides it after coming online Screenshot

The first 5 flaky specs are shown, see all 25 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🔥

// This example support/e2e.js is processed and
// loaded automatically before your test files.
//
// This is a great place to put global configuration and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should deprecate this library, it has a total for 44 weekly downloads: https://www.npmjs.com/package/create-cypress-tests?activeTab=versions

@@ -1,28 +1,29 @@
#!/usr/bin/env node

/* eslint-disable no-console */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we need this? I don't see any console.log added here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see lines 31 & 34

@emilyrohrbough emilyrohrbough changed the title chore: update and cleanup package/example chore: update packages/example deployment script and cleanup package/example Jan 26, 2023
@AtofStryker AtofStryker self-requested a review January 27, 2023 16:03
packages/example/README.md Outdated Show resolved Hide resolved
packages/example/README.md Outdated Show resolved Hide resolved
packages/example/README.md Outdated Show resolved Hide resolved
packages/example/README.md Outdated Show resolved Hide resolved
Co-authored-by: Bill Glesias <bglesias@gmail.com>
@emilyrohrbough emilyrohrbough merged commit b507141 into develop Jan 27, 2023
@emilyrohrbough emilyrohrbough deleted the update-examples-deployment branch January 27, 2023 17:59
tgriesser added a commit that referenced this pull request Jan 31, 2023
* develop:
  chore: fix changlelog section parsing and reference right ENV (#25633)
  feat: Debug page [IATR] (#25488)
  fix(deps): update dependency underscore.string to v3.3.6 🌟 (#25574)
  chore: Use upstream cypress-testing-library again (#25548)
  fix: match alternate edge version string format (#25457)
  chore: update name for graphql batch operations (#25610)
  chore: clean up config for external contibutors (#25552)
  chore: fix childProcess.execSync encoding (#25625)
  chore: update next-version to handle using the next bump package.json… (#25599)
  chore: update packages/example deployment script and cleanup package/example (#25091)
  fix: allow version 9 of the babel-loader peer dependency (#25569)
  docs: remove cypress-example-todomvc-redux from release-process (#25613)
  chore: bump version and remove misleading changelog entry (#25612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants