chore: add support for Angular 16 #26052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanpowell88
changed the title
jordanpowell88
changed the title
jordanpowell88
force-pushed
the
jordanpowell88/angular-16-support
branch
from
cf9154b
to
2f74753
Compare
|
We need to add support for |
jordanpowell88
force-pushed
the
jordanpowell88/angular-16-support
branch
from
2f74753
to
8bb5cb8
Compare
jordanpowell88
force-pushed
the
jordanpowell88/angular-16-support
branch
from
8bb5cb8
to
baaf717
Compare
jordanpowell88
force-pushed
the
jordanpowell88/angular-16-support
branch
from
baaf717
to
598e429
Compare
|
We will need to create a follow up issue to validate/add support for |
Passing run #45757 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
| @@ -127,7 +127,7 @@ describe(`Angular CLI major versions`, () => { | |||
| spec = `${spec},!src/app/components/standalone.component.cy.ts` | |||
| } | |||
|
|
|||
| systemTests.it(`v${majorVersion} with mount tests`, { | |||
| systemTests.it.only(`v${majorVersion} with mount tests`, { | |||
|
@jordanpowell88 should we add the |
lmiller1990
approved these changes
Apr 24, 2023
|
CI green! Just need one more ✅ , thanks @astone123 for the drive by fixes. |
mike-plummer
approved these changes
Apr 24, 2023
tgriesser
added a commit
that referenced
this pull request
May 3, 2023
* feat/protocol: refactor: migrate from windi to tailwind (#26516) chore: update v8 generation vars so that from scratch depends implies updating the metafile (#26472) chore: Update Vite to 4.3.0 (#26553) fix: unify cdp approach to fix devtools in electron (#26573) dependency(deps): update dependency deps-ok to v1.4.1 🌟 (#26612) chore: update 12.11.0 release date (#26587) chore: 12.11.0 release (#26582) chore: implement experimental ESM stub/spy for Vite (#26536) chore: try triggering mouseleave on buttons to ensure that tooltips aren't showing (#26524) chore: add support for Angular 16 (#26052) chore: upgrade Vue to 3.2.47 (#26555) chore: Update v8 snapshot cache (#26537) chore: add missing utm parameters for cloud links to Debug page (#26556) chore: update stalebot to respect new labels and up process rate (#26552) fix: don't display run passing status if Cloud org is over run limit (#26533) chore: update vm2 to 3.9.17 (#26534) feat: display a limit warning on the run navigation component when there are 100 total runs (#26523) chore: Update v8 snapshot cache (#26476) chore: upgrade vm2 (#26495) fix: Treat Video compression 0 as false. (#26503)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR adds support for Angular 16 (set to release in the coming weeks).
signal(s) in Angular will work in CTstandalone.component.tstests that were included insystem-tests/projectangular versions14, 15, and now 16intoproject-fixtures/angular.Steps to test
ANGULAR_MAJOR_VERSIONSinsystem-tests/tests/component_testing_spec.tsto just test version16yarn workspace @tooling/system-tests test component_testing_spec.tsHow has the user experience changed?
The user experience should remain the same
PR Tasks
cypress-documentation?type definitions?