Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try triggering mouseleave on buttons to ensure that tooltips aren't showing when they shouldn't during SelectorPlayground tests #26524

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

astone123
Copy link
Contributor

@astone123 astone123 commented Apr 17, 2023

Additional details

I had SelectorPlayground.cy.tsx flake on me in a different PR, so it looks like the clickAway function that we were using wasn't totally working? Even though we click in a different spot, the tooltip doesn't go away in this case. You can see that clearly in the Cypress video

Triggering a mouseleave event on that button specifically appears to force the tooltip closed, so this might be a better way to deal with the flake?

Steps to test

It's pretty much impossible to test this because it only happens on CI, and not very frequently. I did test that triggering a mouseenter event followed by a mouseleave event does successfully trigger the tooltip and then remove it.

PR Tasks

@astone123 astone123 self-assigned this Apr 17, 2023
@astone123 astone123 changed the title chore: try triggering mouseleave on buttons to ensure that tooltips aren't showing chore: try triggering mouseleave on buttons to ensure that tooltips aren't showing when they shouldn't during SelectorPlayground tests Apr 17, 2023
@cypress
Copy link

cypress bot commented Apr 18, 2023

26 flaky tests on run #45795 ↗︎

0 27269 1307 0 Flakiness 26

Details:

Merge branch 'develop' into playground-selector-tooltip-flake
Project: cypress Commit: 3833f07484
Status: Passed Duration: 21:16 💡
Started: Apr 24, 2023 8:01 PM Ended: Apr 24, 2023 8:22 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output
Flakiness  e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
... > establishes foobar spec bridge Output
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video

The first 5 flaky specs are shown, see all 14 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@warrensplayer warrensplayer requested a review from a team April 24, 2023 19:47
Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@astone123 astone123 merged commit d6f525c into develop Apr 24, 2023
@astone123 astone123 deleted the playground-selector-tooltip-flake branch April 24, 2023 21:08
tgriesser added a commit that referenced this pull request May 3, 2023
* feat/protocol:
  refactor: migrate from windi to tailwind (#26516)
  chore: update v8 generation vars so that from scratch depends implies updating the metafile (#26472)
  chore: Update Vite to 4.3.0 (#26553)
  fix: unify cdp approach to fix devtools in electron (#26573)
  dependency(deps): update dependency deps-ok to v1.4.1 🌟 (#26612)
  chore: update 12.11.0 release date (#26587)
  chore: 12.11.0 release (#26582)
  chore: implement experimental ESM stub/spy for Vite (#26536)
  chore: try triggering mouseleave on buttons to ensure that tooltips aren't showing (#26524)
  chore: add support for Angular 16 (#26052)
  chore: upgrade Vue to 3.2.47 (#26555)
  chore: Update v8 snapshot cache (#26537)
  chore: add missing utm parameters for cloud links to Debug page (#26556)
  chore: update stalebot to respect new labels and up process rate (#26552)
  fix: don't display run passing status if Cloud org is over run limit (#26533)
  chore: update vm2 to 3.9.17 (#26534)
  feat: display a limit warning on the run navigation component when there are 100 total runs (#26523)
  chore: Update v8 snapshot cache (#26476)
  chore: upgrade vm2 (#26495)
  fix: Treat Video compression 0 as false.  (#26503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants