Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Vue to 3.2.47 #26555

Merged
merged 5 commits into from
Apr 24, 2023
Merged

chore: upgrade Vue to 3.2.47 #26555

merged 5 commits into from
Apr 24, 2023

Conversation

astone123
Copy link
Contributor

Additional details

This PR upgrades Vue to version 3.2.47 in the monorepo.

Steps to test

Launch Cypress and do some manual smoke testing to make sure that nothing broke

How has the user experience changed?

n/a

PR Tasks

  • Fix types in mountFragment?
  • [na] Have tests been added/updated?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@astone123 astone123 self-assigned this Apr 20, 2023
@@ -48,6 +48,7 @@ export const registerMountFn = ({ plugins }: MountFnOptions = {}) => {
},
})

// @ts-ignore todo: figure out the correct types
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I messed with the type errors in this file for a while... still not sure what needs to change. We already ignore some types in this file (see line 27)

@astone123 astone123 requested review from lmiller1990 and a team April 20, 2023 20:11
@cypress
Copy link

cypress bot commented Apr 20, 2023

Passing run #45738 ↗︎

0 214 19 0 Flakiness 0

Details:

remove unnecessary ? access
Project: cypress Commit: fa766d54a3
Status: Passed Duration: 10:14 💡
Started: Apr 21, 2023 5:54 PM Ended: Apr 21, 2023 6:04 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@lmiller1990
Copy link
Contributor

Hm, the regression mentioned in #23909 (comment) is no longer an issue?

@lmiller1990
Copy link
Contributor

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astone123
Copy link
Contributor Author

Hm, the regression mentioned in #23909 (comment) is no longer an issue?

Yeah, I didn't see this regression after the upgrade. I'll look into the other regression

@astone123
Copy link
Contributor Author

@lmiller1990 that test was failing because I updated a default prop to satisfy some new types. I updated the assertion so we should be good now

@astone123 astone123 requested review from a team and lmiller1990 April 21, 2023 16:16
Copy link
Contributor

@mike-plummer mike-plummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd percy change, but I'll approve assuming that's just flake

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out, looks good!

I hope we can hit Vue 3.3 soon when it's out. Many nice things landing, like generic components 😎

@lmiller1990 lmiller1990 merged commit 4d6da9c into develop Apr 24, 2023
3 checks passed
@lmiller1990 lmiller1990 deleted the update-vue branch April 24, 2023 00:45
tgriesser added a commit that referenced this pull request May 3, 2023
* feat/protocol:
  refactor: migrate from windi to tailwind (#26516)
  chore: update v8 generation vars so that from scratch depends implies updating the metafile (#26472)
  chore: Update Vite to 4.3.0 (#26553)
  fix: unify cdp approach to fix devtools in electron (#26573)
  dependency(deps): update dependency deps-ok to v1.4.1 🌟 (#26612)
  chore: update 12.11.0 release date (#26587)
  chore: 12.11.0 release (#26582)
  chore: implement experimental ESM stub/spy for Vite (#26536)
  chore: try triggering mouseleave on buttons to ensure that tooltips aren't showing (#26524)
  chore: add support for Angular 16 (#26052)
  chore: upgrade Vue to 3.2.47 (#26555)
  chore: Update v8 snapshot cache (#26537)
  chore: add missing utm parameters for cloud links to Debug page (#26556)
  chore: update stalebot to respect new labels and up process rate (#26552)
  fix: don't display run passing status if Cloud org is over run limit (#26533)
  chore: update vm2 to 3.9.17 (#26534)
  feat: display a limit warning on the run navigation component when there are 100 total runs (#26523)
  chore: Update v8 snapshot cache (#26476)
  chore: upgrade vm2 (#26495)
  fix: Treat Video compression 0 as false.  (#26503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest Vue version in monorepo
3 participants