-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display a limit warning on the run navigation component when there are 100 total runs #26523
Conversation
</ul> | ||
</div> | ||
<div | ||
v-if="runs.length === 100" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We limit this query to 100 runs, so if we have exactly 100 runs, then we're either at or over the limit, so display the message.
4 flaky tests on run #45652 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
cy.origin navigation > #consoleProps > .go() |
Output
Video
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
Test | Artifacts | |
---|---|---|
... > correctly returns currentRetry |
Output
Video
|
|
... > correctly returns currentRetry |
Output
Video
|
|
... > correctly returns currentRetry |
Output
Video
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
e4e9816
to
39bd67e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I did not thoroughly test it yet, I'll do this tomorrow. The changes seem pretty straight forward, I'm confident enough to give this a tentative ✅ .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall functionality looks great. Just need to change where the URL comes from. The App can not assume that the Cloud URLS will keep their current format, but instead use the URLs as provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good after the tests pass!
…ere are 100 total runs (cypress-io#26523)
* feat/protocol: refactor: migrate from windi to tailwind (#26516) chore: update v8 generation vars so that from scratch depends implies updating the metafile (#26472) chore: Update Vite to 4.3.0 (#26553) fix: unify cdp approach to fix devtools in electron (#26573) dependency(deps): update dependency deps-ok to v1.4.1 🌟 (#26612) chore: update 12.11.0 release date (#26587) chore: 12.11.0 release (#26582) chore: implement experimental ESM stub/spy for Vite (#26536) chore: try triggering mouseleave on buttons to ensure that tooltips aren't showing (#26524) chore: add support for Angular 16 (#26052) chore: upgrade Vue to 3.2.47 (#26555) chore: Update v8 snapshot cache (#26537) chore: add missing utm parameters for cloud links to Debug page (#26556) chore: update stalebot to respect new labels and up process rate (#26552) fix: don't display run passing status if Cloud org is over run limit (#26533) chore: update vm2 to 3.9.17 (#26534) feat: display a limit warning on the run navigation component when there are 100 total runs (#26523) chore: Update v8 snapshot cache (#26476) chore: upgrade vm2 (#26495) fix: Treat Video compression 0 as false. (#26503)
Additional details
When we implemented run navigation for the debug page, we missed a requirement to display a message when the number of runs is being limited due to being over 100 total across commits.
This PR adds a message to the bottom of the run navigation list that warns the user that they are not seeing all of the runs, and then links to the project in Cypress Cloud for them to view all of the runs that aren't shown in-app.
Since we limit the graphql query to 100 runs, we will display the message when there are exactly 100 runs returned from the query.
Steps to test
Take a look at the tests that I wrote as well as the Percy snapshots. You can also open a project with 100 or more relevant runs on the debug page and verify that the message appears. I used the react-vite-ts example project to test this manually. Recorded over 100 runs to my production test organization and viewed them in the debug page.
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?