Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Chrome renderer crash to be more terse and up to date #26597

Merged
merged 3 commits into from
May 1, 2023

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Apr 26, 2023

Additional details

In Cypress, when the Chromium renderer crashes, we display a very long error message. Some of the error is not actionable, some of the recommendations are outdated, some of it is repetitive. Overall, the content of the message may be ignored or some of the solutions inapplicable by users.

We wanted to improve the error message to be terse and actionable, leading them to the docs for more detail cypress-io/cypress-documentation#5223.

Steps to test

Snapshots should test this - they need to be updated.

How has the user experience changed?

Before

Screen Shot 2023-04-26 at 3 28 24 PM

After

Screen Shot 2023-04-26 at 3 28 40 PM

What changed

  • Removal of 'sad face' note - this seems irrelevant and not actionable - it's just taking up space to get to a solution.
  • Removed list of arbitrary reasons this may happen (most of these were not actionable, so what's the point), we can list these in the docs if it's really necessary.
  • Removed indication of issue with Docker - this was actually fixed in Cypress, this workaround is no longer necessary. See Docker crashes when renderer process eats up too much memory #350 (comment)
  • Removed duplicate lists with numTestMemory and experimental flag - consolidated into one list for easier readability.
  • Added recommendation to increases resources on the machine
  • Indicated that numTestsKeptInMemory should be change in config during 'cypress open' (this config has no effect during cypress run)

PR Tasks

@jennifer-shehane jennifer-shehane changed the title Update Chrome renderer crash to be more terse and up to date fix: Update Chrome renderer crash to be more terse and up to date Apr 26, 2023
@cypress
Copy link

cypress bot commented Apr 26, 2023

25 flaky tests on run #45938 ↗︎

0 27269 1307 0 Flakiness 25

Details:

Merge branch 'develop' into chrome-renderer-crash-error-update
Project: cypress Commit: aeb4067901
Status: Passed Duration: 19:24 💡
Started: May 1, 2023 5:58 PM Ended: May 1, 2023 6:17 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video

The first 5 flaky specs are shown, see all 14 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mschile mschile requested a review from ryanthemanuel May 1, 2023 19:09
@mschile mschile merged commit 4c45e2e into develop May 1, 2023
@mschile mschile deleted the chrome-renderer-crash-error-update branch May 1, 2023 19:14
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 12, 2023

Released in 12.12.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.12.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants