feat: handle empty response bodies by communicating them to the protocol from the proxy #27606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…col from the proxy
ryanthemanuel
requested review from
AtofStryker,
mschile,
cacieprins,
chrisbreiding and
mjhenkes
11 flaky tests on run #50253 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| cy.origin - cookie login > general behavior > works in a session |
Test Replay
Output
|
|
commands/aliasing.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin aliasing > .as() > supports dom elements inside origin |
Test Replay
Output
|
|
commands/log.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin log > logs in primary and secondary origins |
Test Replay
Output
|
|
integrity.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| Integrity Preservation > <script> tags > preserves integrity with static <script> in HTML with SHA256 integrity. |
Test Replay
Output
|
|
commands/connectors.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin connectors > .each() |
Test Replay
Output
|
|
The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mjhenkes
approved these changes
Aug 21, 2023
AtofStryker
approved these changes
Aug 21, 2023
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Handle empty response bodies by communicating them to the protocol manager from the proxy. We need to ensure that we do this because the protocol manager is expecting the response bodies to come through and won't when they are empty otherwise.
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?