Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use SKIP_RELEASE_CHANGELOG_VALIDATION env var to skip release-… #27670

Merged
merged 6 commits into from
Aug 25, 2023

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Aug 25, 2023

Additional details

The SKIP_RELEASE_CHANGELOG_VALIDATION_FOR_BRANCHES env var in CircleCI can be set to a comma-separated list of branches to skip validating the changelog for the verify-release-readiness workflow for those branches.

Steps to test

How has the user experience changed?

PR Tasks

@chrisbreiding
Copy link
Contributor Author

I changed this so that instead of globally skipping changelog validation, the branch it applies to must be specified in the env var. That way we could skip validation for a release branch while still having validation for interstitial releases from develop cc/ @nagash77

@cypress
Copy link

cypress bot commented Aug 25, 2023

11 flaky tests on run #50492 ↗︎

0 10701 160 0 Flakiness 11

Details:

fix/add tests
Project: cypress Commit: c5f62b050c
Status: Passed Duration: 17:24 💡
Started: Aug 25, 2023 8:17 PM Ended: Aug 25, 2023 8:35 PM
Flakiness  e2e/origin/commands/querying_shadow.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin shadow dom > .shadow() Test Replay Output
Flakiness  e2e/origin/commands/window.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin window > .window() Test Replay Output
Flakiness  e2e/origin/uncaught_errors.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin - uncaught errors > sync errors > appropriately reports negative assertions Test Replay Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
Flakiness  e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output Video

Test Artifacts
cy.origin - cookie login > Max-Age > past max-age -> not accessible via cy.getCookie() Output

The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@chrisbreiding chrisbreiding merged commit c763d85 into release/13.0.0 Aug 25, 2023
3 checks passed
@chrisbreiding chrisbreiding deleted the add-skip-changelog-validation branch August 25, 2023 20:44
@cypress cypress bot mentioned this pull request Aug 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants