Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update net stubbing to not intercept requests sent to dev server #27788

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Sep 11, 2023

Fixes a potential hang when running components tests. See this comment for more details.

Additional details

  • Updated the net-stubbing intercept logic to no longer match on requests meant for the dev server in CT.

Steps to test

Set up a CT project with multiple specs:

  • Spec 1 has a single test that intercepts all requests ('*') and returns a static response.
  • Spec 2 has another test

Run the component specs and verify Cypress does not hang.

How has the user experience changed?

Cypress no longer hangs.

PR Tasks

@cypress
Copy link

cypress bot commented Sep 12, 2023

25 flaky tests on run #50952 ↗︎

0 28100 1345 0 Flakiness 25

Details:

Merge branch 'develop' into mschile/dev_server_intercepts
Project: cypress Commit: 81b3ffa3eb
Status: Passed Duration: 18:49 💡
Started: Sep 12, 2023 4:23 AM Ended: Sep 12, 2023 4:42 AM
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome:beta

View Output Video

Test Artifacts
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
Flakiness  project-setup.cy.ts • 2 flaky tests • launchpad-e2e

View Output Video

Test Artifacts
... > can reconfigure config after CT has been set up Test Replay Output Screenshots
Launchpad: Setup Project > openLink > opens docs link in the default browser Test Replay Output Screenshots

The first 5 flaky specs are shown, see all 11 specs in Cypress Cloud.

Review all test suite changes for PR #27788 ↗︎

@mschile mschile merged commit f8b4c59 into develop Sep 12, 2023
81 of 82 checks passed
@mschile mschile deleted the mschile/dev_server_intercepts branch September 12, 2023 14:22
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 12, 2023

Released in 13.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants