chore: skip binary jobs if we don't have a circle token #27876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
approved these changes
Sep 21, 2023
astone123
commented
Sep 21, 2023
| @@ -593,7 +603,7 @@ commands: | |||
| if [[ <<parameters.type>> == 'ct' ]]; then | |||
| # component tests are located side by side with the source codes. | |||
| # for the app component tests, ignore specs that are known to cause failures on contributor PRs (see https://discuss.circleci.com/t/how-to-exclude-certain-files-from-circleci-test-globbing/41028) | |||
| TESTFILES=$(find src -regextype posix-extended -name '*.cy.*' -not -regex '.*(FileMatch|PromoAction|SelectorPlayground|useDurationFormat|useTestingType|SpecPatterns|DebugPendingRunCounts).cy.*' | circleci tests split --total=$CIRCLE_NODE_TOTAL) | |||
| TESTFILES=$(find src -regextype posix-extended -name '*.cy.*' -not -regex '.*(FileMatch|PromoAction|SelectorPlayground|useDurationFormat|useTestingType|SpecPatterns|DebugPendingRunCounts|DebugRunStates|DebugPageHeader|DebugPendingRunSplash|DebugRunNavigation|DebugRunNavigationLimitMessage).cy.*' | circleci tests split --total=$CIRCLE_NODE_TOTAL) | |||
There was a problem hiding this comment.
Also ignoring some extra CT tests that fail on contributor PRs for some reason
jordanpowell88
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently updated the contributor workflow to block jobs that require a restricted CircleCI context with an approval job. This works, but when the jobs are started after approval, they still don't have the environment variables from the contexts.
This makes it so that we can't build the linux binaries during contributor workflows, because in order to do that, we would need the
CIRCLE_TOKENvariable from the restricted contexts.This PR adds logic to skip building the binary and skip all binary tests if
CIRCLE_TOKENis not in the environment (this will happen on every contributor PR, regardless of who pushes the commit that is running in CI). This way, we can actually get a passing build on contributor PRs if all other steps pass.