Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: Bump ts-node to 10.9.2 #28528

Merged
merged 4 commits into from
Dec 14, 2023
Merged

dependency: Bump ts-node to 10.9.2 #28528

merged 4 commits into from
Dec 14, 2023

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 14, 2023

Additional details

ts-node had a critical error that many people encountered with Typescrit 5.3.2+. TypeStrong/ts-node#2091

Given that many of our users have encountered TS errors with TS 5.3.2+,I thought this may address some of those issues. Probably good to get in regardless.

Steps to test

(verified here: #28385 (comment))

How has the user experience changed?

PR Tasks

@jennifer-shehane jennifer-shehane changed the title fix: Bump ts-node to 10.9.2 dep: Bump ts-node to 10.9.2 Dec 14, 2023
@jennifer-shehane jennifer-shehane changed the title dep: Bump ts-node to 10.9.2 dependency: Bump ts-node to 10.9.2 Dec 14, 2023
Copy link

cypress bot commented Dec 14, 2023

6 flaky tests on run #52807 ↗︎

0 5374 76 0 Flakiness 6

Details:

Add PR link
Project: cypress Commit: 680f5990ea
Status: Passed Duration: 14:54 💡
Started: Dec 14, 2023 5:09 PM Ended: Dec 14, 2023 5:24 PM
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > throws a specific error when file exists when it shouldn't Test Replay
Flakiness  e2e/origin/snapshots.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
cy.origin - snapshots > e2e log verification > Does not take snapshots of XHR/fetch requests from secondary origin if the wrong origin is visited / origin mismatch, but instead the primary origin (existing behavior) Test Replay
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output

Test Artifacts
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
Flakiness  e2e/origin/user_agent_override.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
user agent override > persists modified user agent after cy.go Test Replay

Review all test suite changes for PR #28528 ↗︎

@jennifer-shehane jennifer-shehane merged commit 3725158 into develop Dec 14, 2023
83 of 87 checks passed
@jennifer-shehane jennifer-shehane deleted the bump-ts-node branch December 14, 2023 18:28
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 26, 2023

Released in 13.6.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress fails to start with Typescript ^5.3.2 when using extends in tsconfig.json
3 participants