-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: update tmp to 0.2.3 #29696
dependency: update tmp to 0.2.3 #29696
Conversation
|
68c716c
to
3078774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, some notes on the changelog: https://github.com/raszi/node-tmp/blob/master/README.md#an-important-note-on-compatibility
Thanks for adding the link to the tmp Changelog. I had checked that and I didn't see any issues with upgrading. Node.js |
I will leave updating the branch to you now so that I don't interfere with CI tests running. If I've misunderstood that, then please let me know if there is anything else I should do. 🙂 |
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
tmp
not updated #29693Additional details
Due to the previous dependency configuration tmp@~0.2.1, Cypress projects with older lockfiles could be left with deprecated dependencies installed:
cypress/cli/package.json
Line 62 in 7827656
The warning from pnpm was
The dependency is bumped to
tmp@~0.2.3
in cli/package.json to allow Cypress projects to remove the deprecated dependencies when thecypress
npm module is updated.Newly-installed Cypress projects already use
tmp@0.2.3
Steps to test
should no longer show a deprecation warning. See #29693 for exact repro steps.
How has the user experience changed?
pnpm should no longer show a deprecation warning when Cypress is installed:
PR Tasks
cypress-documentation
?type definitions
?