Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: update tmp to 0.2.3 #29696

Merged

Conversation

MikeMcC399
Copy link
Contributor

Additional details

Due to the previous dependency configuration tmp@~0.2.1, Cypress projects with older lockfiles could be left with deprecated dependencies installed:

"tmp": "~0.2.1",

The warning from pnpm was

 WARN  3 deprecated subdependencies found: glob@7.2.3, inflight@1.0.6, rimraf@3.0.2

The dependency is bumped to tmp@~0.2.3 in cli/package.json to allow Cypress projects to remove the deprecated dependencies when the cypress npm module is updated.

Newly-installed Cypress projects already use tmp@0.2.3

$ npm show tmp dist-tags
{ latest: '0.2.3' }

Steps to test

pnpm add cypress@latest --save-dev

should no longer show a deprecation warning. See #29693 for exact repro steps.

How has the user experience changed?

pnpm should no longer show a deprecation warning when Cypress is installed:

 WARN  3 deprecated subdependencies found: glob@7.2.3, inflight@1.0.6, rimraf@3.0.2

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 changed the title fix(deps): update tmp to 0.2.3 dependency: update tmp to 0.2.3 Jun 18, 2024
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Looks fine, some notes on the changelog: https://github.com/raszi/node-tmp/blob/master/README.md#an-important-note-on-compatibility

Thanks for adding the link to the tmp Changelog. I had checked that and I didn't see any issues with upgrading. Node.js 14 isn't needed anymore and dropping rimraf is a positive change.

@MikeMcC399
Copy link
Contributor Author

I will leave updating the branch to you now so that I don't interfere with CI tests running.

If I've misunderstood that, then please let me know if there is anything else I should do. 🙂

cli/CHANGELOG.md Outdated Show resolved Hide resolved
@jennifer-shehane jennifer-shehane merged commit 54127e3 into cypress-io:develop Jun 20, 2024
67 checks passed
@MikeMcC399 MikeMcC399 deleted the issue-29693-update-tmp-dep branch June 21, 2024 07:06
@MikeMcC399
Copy link
Contributor Author

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 1, 2024

Released in 13.13.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.13.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecated dependencies of tmp not updated
4 participants