-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submission on {enter} to only occur if more than 1 input element that blocks implicit submission when no submit buttons #4574
Conversation
…nt that blocks implicit submission when no submit buttons - Add method to check for inputs of type that block implicit submission - Add test to ensure form is submitted when only 1 field blocking implicit submission.
packages/driver/test/cypress/integration/commands/actions/type_spec.coffee
Outdated
Show resolved
Hide resolved
The way the spec is written reads awkward - it provides the rule and then backs into "the exception" by redefining all the previous inputs as if they are "the rule". I'm suggesting that the naming be re-written in the positive / active form - which is "the rule", and the exception being handled later on which overrides "the rule". These input elements do not BLOCK implicit submission - they actually CREATE implicit submission - and only if there are MORE than 1 of them would that become "the exception" where it DOES NOT implicitly submit the form. The previous language + logic was correct except we needed to filter down / reduce the list of inputs that cause implicit submission. This PR is written in a way where it seems it's doing a whole lot more because of the reversal of the language, making it difficult to understand why or what is actually happening. |
So I also thought that the listing of input types was strange to omit |
Actually, it appears that inputs of type Not exactly sure how to handle this, since we specifically mention supporting |
@jennifer-shehane it was deprecated in favor of |
implicit submission.