-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Replaced the deprecated dep @types/blob-util #6025
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikopetr There's an error being thrown during npm i
of the packages/cli
[cli:install ] set -e
[cli:install ] cp -R node_modules/@types/blob-util types
[cli:install ] /root/cypress/cli/node_modules/shelljs/src/common.js:401
[cli:install ] if (config.fatal) throw e;
[cli:install ] ^
[cli:install ]
[cli:install ] Error: cp: no such file or directory: node_modules/@types/blob-util
[cli:install ] at Object.error (/root/cypress/cli/node_modules/shelljs/src/common.js:110:27)
[cli:install ] at /root/cypress/cli/node_modules/shelljs/src/cp.js:246:14
[cli:install ] at Array.forEach (<anonymous>)
[cli:install ] at Object._cp (/root/cypress/cli/node_modules/shelljs/src/cp.js:243:11)
[cli:install ] at Object.cp (/root/cypress/cli/node_modules/shelljs/src/common.js:384:25)
[cli:install ] at /root/cypress/cli/scripts/post-install.js:20:9
[cli:install ] at Array.forEach (<anonymous>)
[cli:install ] at Object.<anonymous> (/root/cypress/cli/scripts/post-install.js:17:14)
[cli:install ] at Module._compile (internal/modules/cjs/loader.js:868:30)
[cli:install ] at Object.Module._extensions..js (internal/modules/cjs/loader.js:879:10)
[cli:install ] npm ERR! code ELIFECYCLE
[cli:install ] npm ERR! errno 1
[cli:install ] npm ERR! cypress@0.0.0 postinstall: `node ./scripts/post-install.js`
[cli:install ] npm ERR! Exit status 1
[cli:install ] npm ERR!
[cli:install ] npm ERR! Failed at the cypress@0.0.0 postinstall script.
[cli:install ] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[cli:install ]
[cli:install ] npm ERR! A complete log of this run can be found in:
[cli:install ] npm ERR! /root/.npm/_logs/2019-12-23T02_49_26_010Z-debug.log
@nikopetr Will you be able to fix the failing tests? This PR will be closed due to inactivity otherwise. |
@nikopetr @jennifer-shehane If you don't mind, how about fixing this #5780? All I need to do is remove |
Go for it if you want to! |
It's a breaking change. Check why here |
Rebasing this PR against |
I'll fix this when #5780 is done. Maybe I need to open a new PR, though. |
NOTE: https://docs.cypress.io/api/utilities/blob.html should be fixed together. |
6e28b78
to
a0eddc2
Compare
Rebasing against 5.0 branch since this will not make it into 4.0 |
Closing due to inactivity. Please reopen a new PR - against the 5.0 branch since this will be a breaking change that fully addresses the change although I think #5780 may address some of this. |
Additional details
Replaced @types/blob-util dependency. This is a stub types definition. blob-util provides its own type definitions, so you do not need this included.
PR Tasks
type definitions
?