Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replaced the deprecated dep @types/blob-util #6025

Closed
wants to merge 1 commit into from
Closed

[WIP] Replaced the deprecated dep @types/blob-util #6025

wants to merge 1 commit into from

Conversation

nikopetr
Copy link

Additional details

Replaced @types/blob-util dependency. This is a stub types definition. blob-util provides its own type definitions, so you do not need this included.

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 22, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@claassistantio
Copy link

claassistantio commented Dec 22, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikopetr There's an error being thrown during npm i of the packages/cli

[cli:install        ] set -e
[cli:install        ] cp -R node_modules/@types/blob-util types
[cli:install        ] /root/cypress/cli/node_modules/shelljs/src/common.js:401
[cli:install        ]       if (config.fatal) throw e;
[cli:install        ]                         ^
[cli:install        ] 
[cli:install        ] Error: cp: no such file or directory: node_modules/@types/blob-util
[cli:install        ]     at Object.error (/root/cypress/cli/node_modules/shelljs/src/common.js:110:27)
[cli:install        ]     at /root/cypress/cli/node_modules/shelljs/src/cp.js:246:14
[cli:install        ]     at Array.forEach (<anonymous>)
[cli:install        ]     at Object._cp (/root/cypress/cli/node_modules/shelljs/src/cp.js:243:11)
[cli:install        ]     at Object.cp (/root/cypress/cli/node_modules/shelljs/src/common.js:384:25)
[cli:install        ]     at /root/cypress/cli/scripts/post-install.js:20:9
[cli:install        ]     at Array.forEach (<anonymous>)
[cli:install        ]     at Object.<anonymous> (/root/cypress/cli/scripts/post-install.js:17:14)
[cli:install        ]     at Module._compile (internal/modules/cjs/loader.js:868:30)
[cli:install        ]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:879:10)
[cli:install        ] npm ERR! code ELIFECYCLE
[cli:install        ] npm ERR! errno 1
[cli:install        ] npm ERR! cypress@0.0.0 postinstall: `node ./scripts/post-install.js`
[cli:install        ] npm ERR! Exit status 1
[cli:install        ] npm ERR! 
[cli:install        ] npm ERR! Failed at the cypress@0.0.0 postinstall script.
[cli:install        ] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[cli:install        ] 
[cli:install        ] npm ERR! A complete log of this run can be found in:
[cli:install        ] npm ERR!     /root/.npm/_logs/2019-12-23T02_49_26_010Z-debug.log

@jennifer-shehane
Copy link
Member

@nikopetr Will you be able to fix the failing tests? This PR will be closed due to inactivity otherwise.

@sainthkh
Copy link
Contributor

@nikopetr @jennifer-shehane If you don't mind, how about fixing this #5780? All I need to do is remove @types in front of blob-utils.

@nikopetr
Copy link
Author

Go for it if you want to!

@sainthkh
Copy link
Contributor

It's a breaking change. Check why here

@jennifer-shehane jennifer-shehane added the type: breaking change Requires a new major release version label Jan 16, 2020
@jennifer-shehane jennifer-shehane changed the base branch from develop to v4.0-release January 16, 2020 07:24
@jennifer-shehane
Copy link
Member

Rebasing this PR against cypress-4.0 branch since this will be a breaking change. Please address any merge conflicts and update the code to account for the return of a Blob object instead of a Promise.

@sainthkh
Copy link
Contributor

sainthkh commented Jan 16, 2020

I'll fix this when #5780 is done. Maybe I need to open a new PR, though.

@sainthkh
Copy link
Contributor

NOTE: https://docs.cypress.io/api/utilities/blob.html should be fixed together.

@jennifer-shehane jennifer-shehane changed the title Replaced the deprecated dep @types/blob-util [WIP] Replaced the deprecated dep @types/blob-util Jan 22, 2020
@jennifer-shehane
Copy link
Member

Rebasing against 5.0 branch since this will not make it into 4.0

@jennifer-shehane jennifer-shehane changed the base branch from v4.0-release to v5.0 February 3, 2020 16:56
@jennifer-shehane
Copy link
Member

Closing due to inactivity. Please reopen a new PR - against the 5.0 branch since this will be a breaking change that fully addresses the change although I think #5780 may address some of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking change Requires a new major release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants