Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-6736: Fix issue in the SAML Certificate data source #121

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

VictorGFM
Copy link
Contributor

@VictorGFM VictorGFM commented Oct 26, 2021

Description of the change

The TestAccSAMLCertificateDataSource is currently failing in an environment that uses a Control Plane without any existing SSO integration. That generates a cyclic dependency while trying to use the data source in the IDP Okta module. This PR fixes the SAML Certificate data source so that the certificate can be retrieved without depending on an SSO Integration.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

Tested through manual Terraform configuration and running go test -v -run=^TestAccSAMLCertificateDataSource$ using the Edge Control Plane in version v2.24.1

@wcmjunior wcmjunior merged commit f681fd3 into main Oct 27, 2021
@wcmjunior wcmjunior deleted the bugfix/ENG-6736 branch October 27, 2021 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants