Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-8568: Create a data source to return sidecar ID #211

Merged
merged 3 commits into from
May 26, 2022
Merged

ENG-8568: Create a data source to return sidecar ID #211

merged 3 commits into from
May 26, 2022

Conversation

VictorGFM
Copy link
Contributor

@VictorGFM VictorGFM commented May 26, 2022 •
edited
Loading

Description of the change

ENG-8568: Create a data source to return sidecar ID

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

Manual and automated tests.

@VictorGFM VictorGFM marked this pull request as ready for review May 26, 2022 18:23
@VictorGFM VictorGFM requested a review from wcmjunior May 26, 2022 18:24
@VictorGFM VictorGFM linked an issue May 26, 2022 that may be closed by this pull request
Data source to return sidecar ID from name #199
Closed
@wcmjunior wcmjunior merged commit 092c335 into main May 26, 2022
@wcmjunior wcmjunior deleted the feature/ENG-8568 branch May 26, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcmjunior wcmjunior wcmjunior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data source to return sidecar ID from name
2 participants
@VictorGFM @wcmjunior