-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-3601, ENG-4309: Repository binding and new sidecar params #25
Conversation
"cyral_repository": resourceRepository(), | ||
"cyral_sidecar": resourceSidecar(), | ||
"cyral_repository": resourceRepository(), | ||
"cyral_repository_binding": resourceRepositoryBinding(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question, do we want to someday support the entire Cyral API? If so, it's possible to generate tons of Terraform resources from an OpenAPI doc. I started that off for the Terraform Vault Provider here and we could easily grab that code, modify it, and use it here too.
I suggest that because making Terraform resources can get fairly boring and repetitive once you've done one or two, and to cover lots of endpoints it's toil. If we instead work on generating the code, it keeps our lives more fun and gets a lot of bang for the buck on each engineering iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, to clarify, I'm not advocating that we generate this code, it looks great, just future code if we anticipate we'll be doing a lot of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be an awesome idea. I'm not sure if we would be able to do it because our APIs behavior is not 100% uniform, so we have to make sure they behave the same prior automating the resource creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, generating the code would be great indeed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be possible to generate most of the code, but then edit it by hand a little at the end to handle those little nuances.
662294f
to
4e2c9ad
Compare
This code has a known bug in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Well done, Wilson!
Description of the change
cyral_repository
tocyral_sidecar
resources.aws_configuration
section tocyral_sidecar
resource to allow the definition of AWS parameters for sidecars.Type of change
Checklists
Development
Code review
Testing
Tested create, update, destroy and import commands.