Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-9005: Support advanced sidecar options #255

Merged
merged 5 commits into from
Aug 5, 2022
Merged

Conversation

Yowgf
Copy link
Contributor

@Yowgf Yowgf commented Jul 26, 2022

Description of the change

This PR adds support for different bypass modes. See resiliency mode and passthrough mode.

This PR also fixes issues:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

ACC tests cover all bypass modes. Manual testing using all bypass modes, then run terraform show to check if the configuration was properly configured.

Regarding #254, the added ACC test cases cover the issue. Also did manual testing to confirm it is working.

@Yowgf Yowgf marked this pull request as ready for review July 26, 2022 23:36
@wcmjunior wcmjunior removed the request for review from VictorGFM August 5, 2022 16:54
@VictorGFM VictorGFM linked an issue Aug 5, 2022 that may be closed by this pull request
Copy link
Contributor

@VictorGFM VictorGFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Yowgf, thanks

@VictorGFM VictorGFM merged commit 4cade32 into main Aug 5, 2022
@VictorGFM VictorGFM deleted the feature/ENG-9005 branch August 5, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidecar label deletion does not work when list is emptied
3 participants