Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-12107: Add missing validation to idp saml resource #421

Merged
merged 4 commits into from
Jul 13, 2023

Conversation

wcmjunior
Copy link
Contributor

@wcmjunior wcmjunior commented Jul 12, 2023

Description of the change

A missing validation step caused the generic SAML integrations to error out during user log in.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

=== RUN   TestNewClient_WhenTLSSkipVerifyIsEnabled_ThenInsecureSkipVerifyIsTrue
2023/07/12 22:57:11 [DEBUG] Init NewClient
2023/07/12 22:57:11 [DEBUG] TokenSource: &{0xc00000ee70 {0 0} <nil>}
2023/07/12 22:57:11 [DEBUG] End NewClient
--- PASS: TestNewClient_WhenTLSSkipVerifyIsEnabled_ThenInsecureSkipVerifyIsTrue (0.00s)
=== RUN   TestNewClient_WhenTLSSkipVerifyIsDisabled_ThenInsecureSkipVerifyIsFalse
2023/07/12 22:57:11 [DEBUG] Init NewClient
2023/07/12 22:57:11 [DEBUG] TokenSource: &{0xc00000eea0 {0 0} <nil>}
2023/07/12 22:57:11 [DEBUG] End NewClient
--- PASS: TestNewClient_WhenTLSSkipVerifyIsDisabled_ThenInsecureSkipVerifyIsFalse (0.00s)
=== RUN   TestNewClient_WhenClientIDIsEmpty_ThenThrowError
2023/07/12 22:57:11 [DEBUG] Init NewClient
--- PASS: TestNewClient_WhenClientIDIsEmpty_ThenThrowError (0.00s)
=== RUN   TestNewClient_WhenClientSecretIsEmpty_ThenThrowError
2023/07/12 22:57:11 [DEBUG] Init NewClient
--- PASS: TestNewClient_WhenClientSecretIsEmpty_ThenThrowError (0.00s)
=== RUN   TestNewClient_WhenControlPlaneIsEmpty_ThenThrowError
2023/07/12 22:57:11 [DEBUG] Init NewClient
--- PASS: TestNewClient_WhenControlPlaneIsEmpty_ThenThrowError (0.00s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/client     0.039s
=== RUN   TestAccDatalabelDataSource
=== PAUSE TestAccDatalabelDataSource
=== RUN   TestAccIntegrationIdPSAMLDataSource
=== PAUSE TestAccIntegrationIdPSAMLDataSource
=== RUN   TestAccLoggingIntegrationDataSource
=== PAUSE TestAccLoggingIntegrationDataSource
=== RUN   TestAccRepositoryDataSource
=== PAUSE TestAccRepositoryDataSource
=== RUN   TestAccRoleDataSource
=== PAUSE TestAccRoleDataSource
=== RUN   TestAccSAMLCertificateDataSource
=== PAUSE TestAccSAMLCertificateDataSource
=== RUN   TestAccSAMLConfigurationDataSource
=== PAUSE TestAccSAMLConfigurationDataSource
=== RUN   TestAccSidecarBoundPortsDataSource
=== PAUSE TestAccSidecarBoundPortsDataSource
=== RUN   TestAccSidecarCftTemplateDataSource
=== PAUSE TestAccSidecarCftTemplateDataSource
=== RUN   TestAccSidecarIDDataSource
=== PAUSE TestAccSidecarIDDataSource
=== RUN   TestAccSidecarInstanceIDsDataSource
=== PAUSE TestAccSidecarInstanceIDsDataSource
=== RUN   TestAccSidecarListenerDataSource
=== PAUSE TestAccSidecarListenerDataSource
=== RUN   TestIntegrationsData_GetValue_Default
--- PASS: TestIntegrationsData_GetValue_Default (0.00s)
=== RUN   TestIntegrationsData_GetValue_Splunk
--- PASS: TestIntegrationsData_GetValue_Splunk (0.00s)
=== RUN   TestAccProvider
2023/07/12 22:57:12 [DEBUG] Init dataSourceSidecarListener
2023/07/12 22:57:12 [DEBUG] End dataSourceSidecarListener
--- PASS: TestAccProvider (0.00s)
=== RUN   TestAccDatalabelResource
=== PAUSE TestAccDatalabelResource
=== RUN   TestAccDatadogIntegrationResource
=== PAUSE TestAccDatadogIntegrationResource
=== RUN   TestAccELKIntegrationResource
=== PAUSE TestAccELKIntegrationResource
=== RUN   TestAccHCVaultIntegrationResource
=== PAUSE TestAccHCVaultIntegrationResource
=== RUN   TestAccIntegrationIdPSAMLDraftResource
=== PAUSE TestAccIntegrationIdPSAMLDraftResource
=== RUN   TestAccIntegrationIdPSAMLResource
=== PAUSE TestAccIntegrationIdPSAMLResource
=== RUN   TestAccIdPIntegrationResource
=== PAUSE TestAccIdPIntegrationResource
=== RUN   TestAccLogsIntegrationResourceCloudWatch
=== PAUSE TestAccLogsIntegrationResourceCloudWatch
=== RUN   TestAccLogsIntegrationResourceDataDog
=== PAUSE TestAccLogsIntegrationResourceDataDog
=== RUN   TestAccLogsIntegrationResourceElk
=== PAUSE TestAccLogsIntegrationResourceElk
=== RUN   TestAccLogsIntegrationResourceSplunk
=== PAUSE TestAccLogsIntegrationResourceSplunk
=== RUN   TestAccLogsIntegrationResourceSumologic
=== PAUSE TestAccLogsIntegrationResourceSumologic
=== RUN   TestAccLogsIntegrationResourceFluentbit
=== PAUSE TestAccLogsIntegrationResourceFluentbit
=== RUN   TestAccLogstashIntegrationResource
=== PAUSE TestAccLogstashIntegrationResource
=== RUN   TestAccLookerIntegrationResource
=== PAUSE TestAccLookerIntegrationResource
=== RUN   TestAccDuoMFAIntegrationResource
=== PAUSE TestAccDuoMFAIntegrationResource
=== RUN   TestAccPagerDutyIntegrationResource
=== PAUSE TestAccPagerDutyIntegrationResource
=== RUN   TestAccSlackAlertsIntegrationResource
=== PAUSE TestAccSlackAlertsIntegrationResource
=== RUN   TestAccSplunkIntegrationResource
=== PAUSE TestAccSplunkIntegrationResource
=== RUN   TestAccSumoLogicIntegrationResource
=== PAUSE TestAccSumoLogicIntegrationResource
=== RUN   TestAccMsTeamsIntegrationResource
=== PAUSE TestAccMsTeamsIntegrationResource
=== RUN   TestAccPolicyRuleResource
=== PAUSE TestAccPolicyRuleResource
=== RUN   TestPolicyRuleResourceUpgradeV0
--- PASS: TestPolicyRuleResourceUpgradeV0 (0.00s)
=== RUN   TestAccPolicyResource
=== PAUSE TestAccPolicyResource
=== RUN   TestAccRepositoryAccessGatewayResource
=== PAUSE TestAccRepositoryAccessGatewayResource
=== RUN   TestAccRepositoryAccessRulesResource
=== PAUSE TestAccRepositoryAccessRulesResource
=== RUN   TestAccRepositoryBindingResource
=== PAUSE TestAccRepositoryBindingResource
=== RUN   TestAccRepositoryConfAnalysisResource
=== PAUSE TestAccRepositoryConfAnalysisResource
=== RUN   TestRepositoryConfAnalysisResourceUpgradeV0
--- PASS: TestRepositoryConfAnalysisResourceUpgradeV0 (0.00s)
=== RUN   TestAccRepositoryConfAuthResource
=== PAUSE TestAccRepositoryConfAuthResource
=== RUN   TestRepositoryConfAuthResourceUpgradeV0
--- PASS: TestRepositoryConfAuthResourceUpgradeV0 (0.00s)
=== RUN   TestAccRepositoryDatamapResource
=== PAUSE TestAccRepositoryDatamapResource
=== RUN   TestAccRepositoryNetworkAccessPolicyResource
=== PAUSE TestAccRepositoryNetworkAccessPolicyResource
=== RUN   TestAccRepositoryResource
=== PAUSE TestAccRepositoryResource
=== RUN   TestAccRepositoryUserAccountResource
=== PAUSE TestAccRepositoryUserAccountResource
=== RUN   TestAccRoleSSOGroupsResource
=== PAUSE TestAccRoleSSOGroupsResource
=== RUN   TestRoleSSOGroupsResourceUpgradeV0
--- PASS: TestRoleSSOGroupsResourceUpgradeV0 (0.00s)
=== RUN   TestAccRoleResource
=== PAUSE TestAccRoleResource
=== RUN   TestAccSidecarCredentialsResource
=== PAUSE TestAccSidecarCredentialsResource
=== RUN   TestSidecarListenerResource
=== PAUSE TestSidecarListenerResource
=== RUN   TestAccSidecarResource
=== PAUSE TestAccSidecarResource
=== RUN   TestElementsMatch
--- PASS: TestElementsMatch (0.00s)
=== CONT  TestAccDatalabelDataSource
=== CONT  TestAccLogsIntegrationResourceFluentbit
=== CONT  TestAccDatalabelResource
=== CONT  TestAccRepositoryAccessRulesResource
=== CONT  TestAccLogstashIntegrationResource
--- PASS: TestAccLogsIntegrationResourceFluentbit (13.94s)
=== CONT  TestAccLogsIntegrationResourceSumologic
--- PASS: TestAccDatalabelResource (15.00s)
=== CONT  TestAccLogsIntegrationResourceSplunk
--- PASS: TestAccLogstashIntegrationResource (19.35s)
=== CONT  TestAccLogsIntegrationResourceElk
--- PASS: TestAccRepositoryAccessRulesResource (19.47s)
=== CONT  TestAccLogsIntegrationResourceDataDog
--- PASS: TestAccDatalabelDataSource (23.43s)
=== CONT  TestAccIdPIntegrationResource
--- PASS: TestAccLogsIntegrationResourceSumologic (12.07s)
=== CONT  TestAccLogsIntegrationResourceCloudWatch
--- PASS: TestAccLogsIntegrationResourceSplunk (12.21s)
=== CONT  TestAccDatadogIntegrationResource
--- PASS: TestAccLogsIntegrationResourceDataDog (12.15s)
=== CONT  TestAccSidecarListenerDataSource
=== CONT  TestAccSidecarInstanceIDsDataSource
--- PASS: TestAccLogsIntegrationResourceElk (12.67s)
--- PASS: TestAccLogsIntegrationResourceCloudWatch (12.05s)
=== CONT  TestAccSidecarCftTemplateDataSource
--- PASS: TestAccDatadogIntegrationResource (12.01s)
=== CONT  TestAccSidecarIDDataSource
=== CONT  TestAccSidecarBoundPortsDataSource
--- PASS: TestAccSidecarInstanceIDsDataSource (20.63s)
--- PASS: TestAccSidecarIDDataSource (13.61s)
=== CONT  TestAccSAMLConfigurationDataSource
=== CONT  TestAccRoleDataSource
--- PASS: TestAccSidecarListenerDataSource (22.91s)
--- PASS: TestAccSidecarCftTemplateDataSource (16.99s)
=== CONT  TestAccSAMLCertificateDataSource
--- PASS: TestAccIdPIntegrationResource (40.39s)
=== CONT  TestAccLoggingIntegrationDataSource
--- PASS: TestAccSAMLCertificateDataSource (9.81s)
=== CONT  TestAccRepositoryDataSource
--- PASS: TestAccSAMLConfigurationDataSource (13.53s)
=== CONT  TestAccIntegrationIdPSAMLDataSource
--- PASS: TestAccRoleDataSource (13.65s)
=== CONT  TestAccIntegrationIdPSAMLDraftResource
=== CONT  TestAccIntegrationIdPSAMLResource
--- PASS: TestAccSidecarBoundPortsDataSource (18.56s)
--- PASS: TestAccLoggingIntegrationDataSource (14.66s)
=== CONT  TestAccHCVaultIntegrationResource
--- PASS: TestAccIntegrationIdPSAMLDraftResource (15.11s)
=== CONT  TestAccELKIntegrationResource
--- PASS: TestAccRepositoryDataSource (19.85s)
=== CONT  TestAccSlackAlertsIntegrationResource
--- PASS: TestAccHCVaultIntegrationResource (12.97s)
=== CONT  TestAccRepositoryAccessGatewayResource
--- PASS: TestAccIntegrationIdPSAMLDataSource (26.64s)
=== CONT  TestAccRepositoryBindingResource
--- PASS: TestAccSlackAlertsIntegrationResource (10.95s)
=== CONT  TestAccPolicyRuleResource
--- PASS: TestAccELKIntegrationResource (12.96s)
=== CONT  TestAccPolicyResource
--- PASS: TestAccIntegrationIdPSAMLResource (28.40s)
=== CONT  TestAccMsTeamsIntegrationResource
--- PASS: TestAccRepositoryBindingResource (14.61s)
=== CONT  TestAccSumoLogicIntegrationResource
--- PASS: TestAccPolicyResource (11.45s)
=== CONT  TestAccPagerDutyIntegrationResource
--- PASS: TestAccMsTeamsIntegrationResource (11.12s)
=== CONT  TestAccSplunkIntegrationResource
--- PASS: TestAccRepositoryAccessGatewayResource (23.08s)
=== CONT  TestAccDuoMFAIntegrationResource
--- PASS: TestAccPolicyRuleResource (21.07s)
=== CONT  TestAccLookerIntegrationResource
--- PASS: TestAccSumoLogicIntegrationResource (12.04s)
=== CONT  TestAccRepositoryResource
--- PASS: TestAccPagerDutyIntegrationResource (12.98s)
=== CONT  TestAccSidecarResource
=== CONT  TestAccRepositoryNetworkAccessPolicyResource
--- PASS: TestAccSplunkIntegrationResource (12.49s)
--- PASS: TestAccDuoMFAIntegrationResource (12.40s)
=== CONT  TestSidecarListenerResource
=== CONT  TestAccRoleResource
--- PASS: TestAccLookerIntegrationResource (12.56s)
--- PASS: TestAccRepositoryResource (22.78s)
=== CONT  TestAccSidecarCredentialsResource
=== CONT  TestAccRoleSSOGroupsResource
--- PASS: TestAccRepositoryNetworkAccessPolicyResource (23.07s)
--- PASS: TestAccRoleResource (19.61s)
=== CONT  TestAccRepositoryUserAccountResource
--- PASS: TestAccSidecarResource (29.11s)
=== CONT  TestAccRepositoryDatamapResource
=== CONT  TestAccRepositoryConfAnalysisResource
--- PASS: TestAccSidecarCredentialsResource (11.57s)
--- PASS: TestSidecarListenerResource (31.20s)
=== CONT  TestAccRepositoryConfAuthResource
--- PASS: TestAccRoleSSOGroupsResource (17.77s)
--- PASS: TestAccRepositoryConfAnalysisResource (12.56s)
--- PASS: TestAccRepositoryDatamapResource (23.04s)
--- PASS: TestAccRepositoryConfAuthResource (17.57s)
--- PASS: TestAccRepositoryUserAccountResource (41.60s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral      190.659s

@wcmjunior wcmjunior requested a review from VictorGFM July 12, 2023 22:54
@wcmjunior wcmjunior marked this pull request as ready for review July 12, 2023 23:01
@wcmjunior wcmjunior requested a review from Yowgf July 12, 2023 23:33
Copy link
Contributor

@Yowgf Yowgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wcmjunior Thanks for adding this validation! I left some comments that I think can help improve the code. Do you think we could do that before merging?

cyral/resource.go Outdated Show resolved Hide resolved
cyral/resource.go Outdated Show resolved Hide resolved
cyral/resource.go Outdated Show resolved Hide resolved
cyral/resource_cyral_integration_idp_saml.go Outdated Show resolved Hide resolved
Copy link
Contributor

@VictorGFM VictorGFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I have a few refactoring suggestions below that I think could be useful.

cyral/resource.go Outdated Show resolved Hide resolved
cyral/resource.go Outdated Show resolved Hide resolved
cyral/resource.go Outdated Show resolved Hide resolved
cyral/resource.go Outdated Show resolved Hide resolved
cyral/resource.go Outdated Show resolved Hide resolved
cyral/resource_cyral_integration_idp_saml.go Outdated Show resolved Hide resolved
cyral/resource_cyral_integration_idp_saml.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@Yowgf Yowgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcmjunior
Copy link
Contributor Author

Thanks for the suggestions @VictorGFM and @Yowgf. I only skipped the bigger function refactoring suggested by @Yowgf, but all the others made sense. Here are the results of the tests after refactoring with your suggestions:

=== RUN   TestNewClient_WhenTLSSkipVerifyIsEnabled_ThenInsecureSkipVerifyIsTrue
2023/07/13 00:35:36 [DEBUG] Init NewClient
2023/07/13 00:35:36 [DEBUG] TokenSource: &{0xc00000ee70 {0 0} <nil>}
2023/07/13 00:35:36 [DEBUG] End NewClient
--- PASS: TestNewClient_WhenTLSSkipVerifyIsEnabled_ThenInsecureSkipVerifyIsTrue (0.00s)
=== RUN   TestNewClient_WhenTLSSkipVerifyIsDisabled_ThenInsecureSkipVerifyIsFalse
2023/07/13 00:35:36 [DEBUG] Init NewClient
2023/07/13 00:35:36 [DEBUG] TokenSource: &{0xc00000eea0 {0 0} <nil>}
2023/07/13 00:35:36 [DEBUG] End NewClient
--- PASS: TestNewClient_WhenTLSSkipVerifyIsDisabled_ThenInsecureSkipVerifyIsFalse (0.00s)
=== RUN   TestNewClient_WhenClientIDIsEmpty_ThenThrowError
2023/07/13 00:35:36 [DEBUG] Init NewClient
--- PASS: TestNewClient_WhenClientIDIsEmpty_ThenThrowError (0.00s)
=== RUN   TestNewClient_WhenClientSecretIsEmpty_ThenThrowError
2023/07/13 00:35:36 [DEBUG] Init NewClient
--- PASS: TestNewClient_WhenClientSecretIsEmpty_ThenThrowError (0.00s)
=== RUN   TestNewClient_WhenControlPlaneIsEmpty_ThenThrowError
2023/07/13 00:35:36 [DEBUG] Init NewClient
--- PASS: TestNewClient_WhenControlPlaneIsEmpty_ThenThrowError (0.00s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/client     0.038s
=== RUN   TestAccDatalabelDataSource
=== PAUSE TestAccDatalabelDataSource
=== RUN   TestAccIntegrationIdPSAMLDataSource
=== PAUSE TestAccIntegrationIdPSAMLDataSource
=== RUN   TestAccLoggingIntegrationDataSource
=== PAUSE TestAccLoggingIntegrationDataSource
=== RUN   TestAccRepositoryDataSource
=== PAUSE TestAccRepositoryDataSource
=== RUN   TestAccRoleDataSource
=== PAUSE TestAccRoleDataSource
=== RUN   TestAccSAMLCertificateDataSource
=== PAUSE TestAccSAMLCertificateDataSource
=== RUN   TestAccSAMLConfigurationDataSource
=== PAUSE TestAccSAMLConfigurationDataSource
=== RUN   TestAccSidecarBoundPortsDataSource
=== PAUSE TestAccSidecarBoundPortsDataSource
=== RUN   TestAccSidecarCftTemplateDataSource
=== PAUSE TestAccSidecarCftTemplateDataSource
=== RUN   TestAccSidecarIDDataSource
=== PAUSE TestAccSidecarIDDataSource
=== RUN   TestAccSidecarInstanceIDsDataSource
=== PAUSE TestAccSidecarInstanceIDsDataSource
=== RUN   TestAccSidecarListenerDataSource
=== PAUSE TestAccSidecarListenerDataSource
=== RUN   TestIntegrationsData_GetValue_Default
--- PASS: TestIntegrationsData_GetValue_Default (0.00s)
=== RUN   TestIntegrationsData_GetValue_Splunk
--- PASS: TestIntegrationsData_GetValue_Splunk (0.00s)
=== RUN   TestAccProvider
2023/07/13 00:35:37 [DEBUG] Init dataSourceSidecarListener
2023/07/13 00:35:37 [DEBUG] End dataSourceSidecarListener
--- PASS: TestAccProvider (0.00s)
=== RUN   TestAccDatalabelResource
=== PAUSE TestAccDatalabelResource
=== RUN   TestAccDatadogIntegrationResource
=== PAUSE TestAccDatadogIntegrationResource
=== RUN   TestAccELKIntegrationResource
=== PAUSE TestAccELKIntegrationResource
=== RUN   TestAccHCVaultIntegrationResource
=== PAUSE TestAccHCVaultIntegrationResource
=== RUN   TestAccIntegrationIdPSAMLDraftResource
=== PAUSE TestAccIntegrationIdPSAMLDraftResource
=== RUN   TestAccIntegrationIdPSAMLResource
=== PAUSE TestAccIntegrationIdPSAMLResource
=== RUN   TestAccIdPIntegrationResource
=== PAUSE TestAccIdPIntegrationResource
=== RUN   TestAccLogsIntegrationResourceCloudWatch
=== PAUSE TestAccLogsIntegrationResourceCloudWatch
=== RUN   TestAccLogsIntegrationResourceDataDog
=== PAUSE TestAccLogsIntegrationResourceDataDog
=== RUN   TestAccLogsIntegrationResourceElk
=== PAUSE TestAccLogsIntegrationResourceElk
=== RUN   TestAccLogsIntegrationResourceSplunk
=== PAUSE TestAccLogsIntegrationResourceSplunk
=== RUN   TestAccLogsIntegrationResourceSumologic
=== PAUSE TestAccLogsIntegrationResourceSumologic
=== RUN   TestAccLogsIntegrationResourceFluentbit
=== PAUSE TestAccLogsIntegrationResourceFluentbit
=== RUN   TestAccLogstashIntegrationResource
=== PAUSE TestAccLogstashIntegrationResource
=== RUN   TestAccLookerIntegrationResource
=== PAUSE TestAccLookerIntegrationResource
=== RUN   TestAccDuoMFAIntegrationResource
=== PAUSE TestAccDuoMFAIntegrationResource
=== RUN   TestAccPagerDutyIntegrationResource
=== PAUSE TestAccPagerDutyIntegrationResource
=== RUN   TestAccSlackAlertsIntegrationResource
=== PAUSE TestAccSlackAlertsIntegrationResource
=== RUN   TestAccSplunkIntegrationResource
=== PAUSE TestAccSplunkIntegrationResource
=== RUN   TestAccSumoLogicIntegrationResource
=== PAUSE TestAccSumoLogicIntegrationResource
=== RUN   TestAccMsTeamsIntegrationResource
=== PAUSE TestAccMsTeamsIntegrationResource
=== RUN   TestAccPolicyRuleResource
=== PAUSE TestAccPolicyRuleResource
=== RUN   TestPolicyRuleResourceUpgradeV0
--- PASS: TestPolicyRuleResourceUpgradeV0 (0.00s)
=== RUN   TestAccPolicyResource
=== PAUSE TestAccPolicyResource
=== RUN   TestAccRepositoryAccessGatewayResource
=== PAUSE TestAccRepositoryAccessGatewayResource
=== RUN   TestAccRepositoryAccessRulesResource
=== PAUSE TestAccRepositoryAccessRulesResource
=== RUN   TestAccRepositoryBindingResource
=== PAUSE TestAccRepositoryBindingResource
=== RUN   TestAccRepositoryConfAnalysisResource
=== PAUSE TestAccRepositoryConfAnalysisResource
=== RUN   TestRepositoryConfAnalysisResourceUpgradeV0
--- PASS: TestRepositoryConfAnalysisResourceUpgradeV0 (0.00s)
=== RUN   TestAccRepositoryConfAuthResource
=== PAUSE TestAccRepositoryConfAuthResource
=== RUN   TestRepositoryConfAuthResourceUpgradeV0
--- PASS: TestRepositoryConfAuthResourceUpgradeV0 (0.00s)
=== RUN   TestAccRepositoryDatamapResource
=== PAUSE TestAccRepositoryDatamapResource
=== RUN   TestAccRepositoryNetworkAccessPolicyResource
=== PAUSE TestAccRepositoryNetworkAccessPolicyResource
=== RUN   TestAccRepositoryResource
=== PAUSE TestAccRepositoryResource
=== RUN   TestAccRepositoryUserAccountResource
=== PAUSE TestAccRepositoryUserAccountResource
=== RUN   TestAccRoleSSOGroupsResource
=== PAUSE TestAccRoleSSOGroupsResource
=== RUN   TestRoleSSOGroupsResourceUpgradeV0
--- PASS: TestRoleSSOGroupsResourceUpgradeV0 (0.00s)
=== RUN   TestAccRoleResource
=== PAUSE TestAccRoleResource
=== RUN   TestAccSidecarCredentialsResource
=== PAUSE TestAccSidecarCredentialsResource
=== RUN   TestSidecarListenerResource
=== PAUSE TestSidecarListenerResource
=== RUN   TestAccSidecarResource
=== PAUSE TestAccSidecarResource
=== RUN   TestElementsMatch
--- PASS: TestElementsMatch (0.00s)
=== CONT  TestAccIntegrationIdPSAMLDataSource
=== CONT  TestAccLogstashIntegrationResource
=== CONT  TestAccLogsIntegrationResourceSumologic
=== CONT  TestAccRepositoryBindingResource
=== CONT  TestAccLogsIntegrationResourceSplunk
--- PASS: TestAccLogsIntegrationResourceSplunk (15.41s)
=== CONT  TestAccLogsIntegrationResourceElk
--- PASS: TestAccLogsIntegrationResourceSumologic (15.42s)
=== CONT  TestAccLogsIntegrationResourceDataDog
--- PASS: TestAccRepositoryBindingResource (19.26s)
=== CONT  TestAccLogsIntegrationResourceFluentbit
--- PASS: TestAccLogstashIntegrationResource (19.92s)
=== CONT  TestAccIdPIntegrationResource
--- PASS: TestAccIntegrationIdPSAMLDataSource (23.21s)
=== CONT  TestAccIntegrationIdPSAMLResource
--- PASS: TestAccLogsIntegrationResourceDataDog (11.53s)
=== CONT  TestAccLogsIntegrationResourceCloudWatch
--- PASS: TestAccLogsIntegrationResourceElk (12.58s)
=== CONT  TestAccHCVaultIntegrationResource
--- PASS: TestAccLogsIntegrationResourceFluentbit (11.50s)
=== CONT  TestAccIntegrationIdPSAMLDraftResource
--- PASS: TestAccLogsIntegrationResourceCloudWatch (12.31s)
=== CONT  TestAccELKIntegrationResource
--- PASS: TestAccHCVaultIntegrationResource (11.86s)
=== CONT  TestAccDatadogIntegrationResource
--- PASS: TestAccIntegrationIdPSAMLDraftResource (16.09s)
=== CONT  TestAccDatalabelResource
--- PASS: TestAccIntegrationIdPSAMLResource (26.27s)
=== CONT  TestAccSidecarInstanceIDsDataSource
--- PASS: TestAccELKIntegrationResource (12.65s)
=== CONT  TestAccSidecarIDDataSource
--- PASS: TestAccDatadogIntegrationResource (12.13s)
=== CONT  TestAccSidecarListenerDataSource
=== CONT  TestAccSidecarBoundPortsDataSource
--- PASS: TestAccDatalabelResource (12.78s)
--- PASS: TestAccIdPIntegrationResource (43.89s)
=== CONT  TestAccSidecarCftTemplateDataSource
--- PASS: TestAccSidecarIDDataSource (13.36s)
=== CONT  TestAccSAMLConfigurationDataSource
--- PASS: TestAccSidecarInstanceIDsDataSource (15.89s)
=== CONT  TestAccRoleDataSource
--- PASS: TestAccSidecarListenerDataSource (22.29s)
=== CONT  TestAccSAMLCertificateDataSource
--- PASS: TestAccSidecarBoundPortsDataSource (16.95s)
=== CONT  TestAccLoggingIntegrationDataSource
--- PASS: TestAccSAMLConfigurationDataSource (13.40s)
=== CONT  TestAccRepositoryDataSource
--- PASS: TestAccRoleDataSource (13.49s)
=== CONT  TestAccDatalabelDataSource
--- PASS: TestAccSidecarCftTemplateDataSource (17.05s)
=== CONT  TestAccRepositoryUserAccountResource
--- PASS: TestAccSAMLCertificateDataSource (9.60s)
=== CONT  TestAccSidecarResource
--- PASS: TestAccLoggingIntegrationDataSource (13.73s)
=== CONT  TestSidecarListenerResource
--- PASS: TestAccRepositoryDataSource (18.38s)
=== CONT  TestAccSidecarCredentialsResource
--- PASS: TestAccDatalabelDataSource (21.77s)
=== CONT  TestAccRoleResource
--- PASS: TestAccSidecarCredentialsResource (11.80s)
=== CONT  TestAccRoleSSOGroupsResource
--- PASS: TestAccSidecarResource (27.79s)
=== CONT  TestAccRepositoryNetworkAccessPolicyResource
--- PASS: TestSidecarListenerResource (30.56s)
=== CONT  TestAccRepositoryResource
--- PASS: TestAccRepositoryUserAccountResource (41.40s)
=== CONT  TestAccRepositoryDatamapResource
--- PASS: TestAccRoleResource (21.70s)
=== CONT  TestAccSplunkIntegrationResource
--- PASS: TestAccRoleSSOGroupsResource (18.06s)
=== CONT  TestAccRepositoryAccessRulesResource
--- PASS: TestAccSplunkIntegrationResource (12.38s)
=== CONT  TestAccRepositoryAccessGatewayResource
--- PASS: TestAccRepositoryNetworkAccessPolicyResource (24.14s)
=== CONT  TestAccPolicyResource
--- PASS: TestAccRepositoryResource (23.37s)
=== CONT  TestAccMsTeamsIntegrationResource
--- PASS: TestAccRepositoryAccessRulesResource (17.71s)
=== CONT  TestAccSumoLogicIntegrationResource
--- PASS: TestAccRepositoryDatamapResource (22.66s)
=== CONT  TestAccPolicyRuleResource
--- PASS: TestAccPolicyResource (11.88s)
=== CONT  TestAccSlackAlertsIntegrationResource
--- PASS: TestAccMsTeamsIntegrationResource (11.18s)
=== CONT  TestAccPagerDutyIntegrationResource
--- PASS: TestAccRepositoryAccessGatewayResource (21.36s)
=== CONT  TestAccRepositoryConfAnalysisResource
--- PASS: TestAccSumoLogicIntegrationResource (12.41s)
=== CONT  TestAccLookerIntegrationResource
=== CONT  TestAccDuoMFAIntegrationResource
--- PASS: TestAccSlackAlertsIntegrationResource (11.72s)
--- PASS: TestAccPolicyRuleResource (21.60s)
=== CONT  TestAccRepositoryConfAuthResource
--- PASS: TestAccPagerDutyIntegrationResource (12.48s)
--- PASS: TestAccLookerIntegrationResource (11.92s)
--- PASS: TestAccRepositoryConfAnalysisResource (14.47s)
--- PASS: TestAccDuoMFAIntegrationResource (12.02s)
--- PASS: TestAccRepositoryConfAuthResource (17.88s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral      184.564s

@wcmjunior wcmjunior merged commit c937978 into main Jul 13, 2023
@wcmjunior wcmjunior deleted the bugfix/ENG-12107 branch July 13, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants