Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pols should be XX, XY, YX, YY #25

Open
tremou opened this issue Jul 15, 2024 · 5 comments
Open

Pols should be XX, XY, YX, YY #25

tremou opened this issue Jul 15, 2024 · 5 comments

Comments

@tremou
Copy link

tremou commented Jul 15, 2024

Does it work only with linear feeds?
I tried it on VLA -C band data and I get the following error.

Traceback (most recent call last):
  File "/lustre/aoc/sciops/etremou/soft/DynSpecMS/splitcatalog_fixes/DynSpecMS/scripts/ms2dynspec.py", line 237, in <module>
    main(args)
  File "/lustre/aoc/sciops/etremou/soft/DynSpecMS/splitcatalog_fixes/DynSpecMS/scripts/ms2dynspec.py", line 150, in main
    D = ClassDynSpecMS(ListMSName=MSList, 
  File "/users/etremou/.local/lib/python3.9/site-packages/DynSpecMS-0.1.0-py3.9.egg/DynSpecMS/ClassDynSpecMS.py", line 148, in __init__
    self.ReadMSInfos()
  File "/users/etremou/.local/lib/python3.9/site-packages/DynSpecMS-0.1.0-py3.9.egg/DynSpecMS/ClassDynSpecMS.py", line 600, in ReadMSInfos
    raise ValueError("Pols should be XX, XY, YX, YY")
ValueError: Pols should be XX, XY, YX, YY

Thanks,
Lilia

@o-smirnov
Copy link
Collaborator

o-smirnov commented Jul 16, 2024 via email

@talonmyburgh
Copy link
Collaborator

@tremou have a try with my branch SplitCatalog_fixes. I use that for MeerKAT datasets. Can also just pip install it normally (i.e. pip install <path-to-cloned-folder>).

@tremou
Copy link
Author

tremou commented Jul 16, 2024

thanks. I do use the SplitCatalog_fixes branch, and I run it without any issue in MeerKAT data since it's XX, YY , etc. the issue is present is with the RR, LL, etc at VLA data.

@talonmyburgh
Copy link
Collaborator

Ah I see... apologies, I did not read that correctly. Yes, you are correct it appears from the code that measurement set column "CORR_TYPE" must be [9,10,11,12] which correspond to "XX, XY, YX, YY".
@cyriltasse might be able to comment further on what would be required to support other "CORR_TYPE".

@cyriltasse
Copy link
Owner

I have this raise condition because the 4 lines here

GOut[..., 0] = 0.5*(Gn[..., 0] + Gn[..., 3]) # I = 0.5(XX + YY)
, ie the mapping from cube slices to IQUV should be different for other corr types. It's quite simple to change but I'm in hollidays right now! @tremou you could add a corr_type attribute to the class and change the mapping and the raise condition accordingly? (if you do so, create a separate branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants