Support byte sizes in label filters. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch extends the duration label filter with support for byte sizes such as `1kB` and `42MiB`.
cyriltovena
reviewed
Oct 12, 2020
cyriltovena
reviewed
Oct 12, 2020
cyriltovena
reviewed
Oct 12, 2020
cyriltovena
reviewed
Oct 12, 2020
jeschkies
force-pushed
the
karsten/bytes-filter
branch
from
d82fa39
to
78973cf
Compare
jeschkies
referenced
this pull request
in jeschkies/loki
Dec 21, 2021
* add TestCreateLokiStack_WhenGetReturnsNotFound_DoesNotError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This patch extends the duration label filter with support for byte sizes
such as
1kBand42MiB.Checklist