Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldap_timeout setting is unused? #31

Closed
elliefm opened this issue Sep 26, 2016 · 1 comment
Closed

ldap_timeout setting is unused? #31

elliefm opened this issue Sep 26, 2016 · 1 comment
Labels
2.5 affects 2.5 3.0 affects 3.0

Comments

@elliefm
Copy link
Contributor

elliefm commented Sep 26, 2016

Instead, ldap_time_limit is used for both timeout and time limit:

$ack IMAPOPT_LDAP_TIMEOUT
lib/imapopts.h
194:  IMAPOPT_LDAP_TIMEOUT,

lib/imapopts.c
1020:  { IMAPOPT_LDAP_TIMEOUT, "ldap_timeout", 0, OPT_INT,
$ack IMAPOPT_LDAP_TIME_LIMIT
ptclient/ldap.c
464:    ptsm->timeout.tv_sec = config_getint(IMAPOPT_LDAP_TIME_LIMIT);
482:    ptsm->time_limit = config_getint(IMAPOPT_LDAP_TIME_LIMIT);

lib/imapopts.h
193:  IMAPOPT_LDAP_TIME_LIMIT,

lib/imapopts.c
1015:  { IMAPOPT_LDAP_TIME_LIMIT, "ldap_time_limit", 0, OPT_INT,

Not sure how this interacts with a service-specific interpretation of "ldap" + "timeout" (but, we don't provide an ldap service, so I guess maybe it doesn't).

@elliefm elliefm added 3.0 affects 3.0 2.5 affects 2.5 labels Sep 26, 2016
@elliefm
Copy link
Contributor Author

elliefm commented Sep 27, 2016

These two settings both have the same default value, which might explain how this has gone as long as it has without being noticed

elliefm added a commit that referenced this issue Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.5 affects 2.5 3.0 affects 3.0
Projects
None yet
Development

No branches or pull requests

1 participant