Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Is there any code style for this project for contributing to the repo #271

Closed
lxymahatma opened this issue Mar 28, 2024 · 2 comments

Comments

@lxymahatma
Copy link

lxymahatma commented Mar 28, 2024

Last time when I trying to dig into why the code generator doesn't work for my project, I cloned the repo and open it with Rider. The project seems a little bit messy so i actually take some time to locate the method i want to find. Also, Rider gives me tons of suggestions on refactoring the code, like use => instead of writing return, use ; instead of { } with empty classes, remove unneeded this., etc. But cz i'm not familiar with the actual things happening behind things I'm a bit afraid of changing those stuff

There are also some small issues with naming i guess(?
like the SuppressDefaultInitialization Attributes, i think theoretically the it should end with 'Attribute'

So like, is it possible for me to do a pr to correct those styles 👀

@neuecc
Copy link
Member

neuecc commented Apr 5, 2024

SuppressDefaultInitialization is a new addition and I did not review it enough.
This should add Attribtue, thanks.

Rider's suggesion is too meddlesome.
I would not try to apply it 100%.

@lxymahatma
Copy link
Author

SuppressDefaultInitialization is a new addition and I did not review it enough. This should add Attribtue, thanks.

Rider's suggesion is too meddlesome. I would not try to apply it 100%.

oh i see, so maybe i could make a pr for some style changes(?
imo some style changes make the code more easier to read

@neuecc neuecc closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants