Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID Collisions When Generated from Strings #34

Closed
virtushda opened this issue Aug 24, 2021 · 3 comments
Closed

ID Collisions When Generated from Strings #34

virtushda opened this issue Aug 24, 2021 · 3 comments
Labels

Comments

@virtushda
Copy link

virtushda commented Aug 24, 2021

We're using Ulid to generate unique IDs based on names.
For the most part it works, but we're seeing a lot of ID collisions in certain circumstances...

For instance, these two collide:
image
image

I'm sorry if I'm misunderstanding how this works, but I was under the impression that Ulids generated should be more unique than this?

This is the implementation: (Sorry, code tags butchered everything..)
image

.ToUlid:
image

@neuecc
Copy link
Member

neuecc commented Aug 24, 2021

Ulid representation is [Time + Randomness].
andalso, Parse expects ulid's string representation.
Isn't it wrong to express name as Ulid?

@virtushda
Copy link
Author

I guess I misunderstood what this system is meant to do!

@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants