Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 to tests #28

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Add Python 3.10 to tests #28

merged 3 commits into from
Feb 7, 2023

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Jan 31, 2023

Description

Through a comment in #8 (comment) I noticed there is not yet testing for Python 3.10, which could be cause for incompatibilities or errors. This PR adds Python 3.10 to Dagger and the associated automated Github Action tests for this repo.

While working on this I also found that other dependencies needed to be updated, notably Poetry 1.2 -> 1.3, along with various packages. I took a moment to address this to avoid some upstream issues as well.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Collaborator

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Sorry that this took so long for me to approve.

@d33bs
Copy link
Member Author

d33bs commented Feb 7, 2023

No worries and thank you @falquaddoomi and @gwaybio for your reviews!

@d33bs d33bs merged commit 4b4fbbb into cytomining:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants