Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update ruff to 0.3.4 #386

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Mar 30, 2024

Description

This updates ruff to the latest version and applies the formatting to pycytominer repo. This set of changes are formatting/whitespace only.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@kenibrewer kenibrewer marked this pull request as ready for review March 30, 2024 00:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (af5a4ef) to head (3c5eafd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #386   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files          56       56           
  Lines        3137     3137           
=======================================
  Hits         2979     2979           
  Misses        158      158           
Flag Coverage Δ
unittests 94.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kenibrewer kenibrewer mentioned this pull request Mar 30, 2024
13 tasks
@kenibrewer kenibrewer requested a review from d33bs March 30, 2024 00:33
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, LGTM, only had a minor comment about where the versions might be specified for ruff. Please don't hesitate to let me know if you have any questions.

.pre-commit-config.yaml Show resolved Hide resolved
@kenibrewer kenibrewer merged commit 1a1590c into cytomining:main Apr 1, 2024
11 checks passed
@kenibrewer kenibrewer deleted the ci/update-ruff-to-0.3.4 branch April 1, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants