fix: Renames tutorials train_df to input_df #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devanubis
changed the title
devanubis
force-pushed
the
rename_train_df_input_df
branch
from
058acd0
to
80a62c8
Compare
czagoni
approved these changes
Jan 14, 2022
|
Thanks a lot @devanubis and sorry for late response. Yes, deps update would be great too! |
|
Thanks, we're evaluating a few options for thermal models at the moment but if we do pick darkgreybox we'd contribute updates and possibly do some profiling too. |
|
Awesome - very interested in what you find (and if you pick something else would love to learn about it)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
I did these whilst working on updating dependencies in my fork, as we need newer version of pandas and numpy. Would you accept PRs back for those too?