Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example usage of ping.size #74

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

stevegrey2
Copy link
Contributor

From latest, the parameter is ping.size. With this, I get ping_rtt_best_seconds, ping_rtt_mean_seconds etc. metrics, with the existing example using ping.payload-size all I get is ping_loss_ratio.

docker exec -it ping_exporter /bin/sh
/app # ./ping_exporter --help
usage: ping_exporter [<flags>] [<targets>...]

Flags:
  --help                        Show context-sensitive help (also try --help-long and --help-man).
  --version                     Print version information
  --web.listen-address=":9427"  Address on which to expose metrics and web interface
  --web.telemetry-path="/metrics"  
                                Path under which to expose metrics
  --config.path=""              Path to config file
  --ping.interval=5s            Interval for ICMP echo requests
  --ping.timeout=4s             Timeout for ICMP echo request
  --ping.size=56                Payload size for ICMP echo requests
  --ping.history-size=10        Number of results to remember per target
  --dns.refresh=1m              Interval for refreshing DNS records and updating targets accordingly (0 if disabled)
  --dns.nameserver=""           DNS server used to resolve hostname of targets
  --options.disable-ipv6        Disable DNS from resolving IPv6 AAAA records
  --log.level="info"            Only log messages with the given severity or above. Valid levels: [debug, info, warn, error,
                                fatal]
  --metrics.deprecated="disable"  
                                Enable or disable deprecated metrics (`ping_rtt_ms{type=best|worst|mean|std_dev}`). Valid
                                choices: [enable, disable]
  --metrics.rttunit="s"         Export ping results as either seconds (default), or milliseconds (deprecated), or both (for
                                migrations). Valid choices: [s, ms, both]

Args:
  [<targets>]  A list of targets to ping

From latest, the parameter is `ping.size`. With this, I get `ping_rtt_best_seconds`, `ping_rtt_mean_seconds` etc. metrics, with the existing example all I get is `ping_loss_ratio`.

```
docker exec -it ping_exporter /bin/sh
/app # ./ping_exporter --help
usage: ping_exporter [<flags>] [<targets>...]

Flags:
  --help                        Show context-sensitive help (also try --help-long and --help-man).
  --version                     Print version information
  --web.listen-address=":9427"  Address on which to expose metrics and web interface
  --web.telemetry-path="/metrics"  
                                Path under which to expose metrics
  --config.path=""              Path to config file
  --ping.interval=5s            Interval for ICMP echo requests
  --ping.timeout=4s             Timeout for ICMP echo request
  --ping.size=56                Payload size for ICMP echo requests
  --ping.history-size=10        Number of results to remember per target
  --dns.refresh=1m              Interval for refreshing DNS records and updating targets accordingly (0 if disabled)
  --dns.nameserver=""           DNS server used to resolve hostname of targets
  --options.disable-ipv6        Disable DNS from resolving IPv6 AAAA records
  --log.level="info"            Only log messages with the given severity or above. Valid levels: [debug, info, warn, error,
                                fatal]
  --metrics.deprecated="disable"  
                                Enable or disable deprecated metrics (`ping_rtt_ms{type=best|worst|mean|std_dev}`). Valid
                                choices: [enable, disable]
  --metrics.rttunit="s"         Export ping results as either seconds (default), or milliseconds (deprecated), or both (for
                                migrations). Valid choices: [s, ms, both]

Args:
  [<targets>]  A list of targets to ping
```
@czerwonk czerwonk merged commit 1a899ad into czerwonk:master Sep 7, 2022
@czerwonk
Copy link
Owner

czerwonk commented Sep 7, 2022

Thanks for contributing! 👍

@stevegrey2 stevegrey2 deleted the patch-1 branch September 7, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants