Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

Needs testing on Windows #1

Closed
cznic opened this issue Jun 9, 2017 · 5 comments
Closed

Needs testing on Windows #1

cznic opened this issue Jun 9, 2017 · 5 comments

Comments

@cznic
Copy link
Owner

cznic commented Jun 9, 2017

Hi @steffengy, may I please ask you to run go test on windows_{amd64,386}? Thank you in advance.
@cznic
Copy link
Owner Author

cznic commented Jun 9, 2017

Updates cznic/sqlite#12.

@steffengy
Copy link
Collaborator

Running go test in cznic/memory just PASSes.
Anything else you'd like me to try or any output you need?

@cznic
Copy link
Owner Author

cznic commented Jun 10, 2017

Running go test in cznic/memory just PASSes.

Good! Thanks for testing.

Anything else you'd like me to try or any output you need?

Thanks, no, that's all I wanted to know before switching CRT to use this package.

@cznic cznic closed this as completed Jun 10, 2017
@cznic
Copy link
Owner Author

cznic commented Jun 13, 2017

Tests no more pass on Windows, reopening. See: cznic/sqlite#12 (comment)

@cznic cznic reopened this Jun 13, 2017
cznic pushed a commit that referenced this issue Jun 13, 2017
Fix unmap on Windows. Updates #1. Updates cznic/sqlite#12.
8282d1c 
Fortunately OS page size on Windows is already bigger than on Linux so
the band-aid is to set pagseSize equal to osPageSize.

	modified:   memory.go
	modified:   mmap_unix.go
	modified:   mmap_windows.go
@cznic
Copy link
Owner Author

cznic commented Jun 13, 2017

Fixed. Confirmed here: cznic/sqlite#12 (comment).

@cznic cznic closed this as completed Jun 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cznic @steffengy