Update int range detection for Python 3 #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3 unified ints and longs into a single int type. The long type is still available in Cython as an alias to int.
bryan-koroleski-fivestars
force-pushed
the
master
branch
from
fc9c719
to
37d3d2e
Compare
cztomczak
reviewed
Feb 14, 2021
src/javascript_bindings.pyx
Outdated
| return True | ||
| if INT_MIN <= value <= INT_MAX: | ||
| return True | ||
| return "long" |
There was a problem hiding this comment.
Looks like bug. This won't allow long values inside nested structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type checks in
javascript_bindings.pyxandprocess_message_utils.pyxcurrently only work in Python 2. Python 3 unifiedintandlonginto a single arbitrarily sizedinttype. The end result is that these checks fail to detect integers larger than 32-bits. This change:INT_MINandINT_MAXfromlimits.hintrange check to work with both Python 2 and Python 3I've run the tests and examples on Win10 with Python 3.8.6 32-bit and can confirm this change works as expected.