Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

LibGDX 1.9.11 compatibility. #99

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Conversation

metaphore
Copy link
Contributor

Same update as the previous one - #95.
Only required changes to comply with the most recent LibGDX API changes.
I've done some basic testing for LML and Kiwi, but it should be fine as there is not much change. The project version is lifted to 1.91.9.11 and ready to roll.

@czyzby I'd appreciate it if you could build and push these changes as a snapshot release, please.

@czyzby
Copy link
Owner

czyzby commented Aug 22, 2020

Thanks for the update, I'll try to upload the snapshots today.

@czyzby czyzby merged commit 7da8522 into czyzby:master Aug 22, 2020
@czyzby
Copy link
Owner

czyzby commented Aug 22, 2020

@metaphore I've successfully built and uploaded the snapshot version. Can you check if it's alright?

Also, have you thought about forking and maintaining the project? I believe @tommyettinger maintains a fork of the library for gdx-liftoff, so you two could potentially collaborate.

@metaphore
Copy link
Contributor Author

Thanks, that was quick!

I checked it locally and it seems the artifacts are available just fine, but for some reason, the gdx-lml jars don't contain any classes. I had no problem installing to my local Maven repo, might be something on your end, could you please have a look into it?

image

And regards maintaining the fork, I'd really love to do it, but I'm afraid my focus is mainly outside of LibGDX right now and I mostly maintain my old projects. But LML is definitely the first in the line, will see how it goes.

@czyzby
Copy link
Owner

czyzby commented Aug 22, 2020

@metaphore Are you sure? When I downloaded the jar directly from Sonatype snapshots, it seems that all classes are there. My local jar files also seem to contain all calsses. Maybe try forcing Gradle to redownload the dependencies?

@tommyettinger
Copy link

Yay, 1.9.11! I remember I needed to change some things in gdx-liftoff's fork where they weren't editable using normal LML, though I suspect my changes were narrowly-focused toward some appearance setting in liftoff. I can generate projects that use 1.9.11 even if gdx-liftoff itself uses 1.9.10, so unless there's some new feature, I don't think I really need to update right away.

There is a new platform that's at least somewhat-supported in the 1.9.12-SNAPSHOT versions, ARM Linux (for Raspberry Pi and such). If liftoff switches to 1.9.11 for itself, I'd probably have to strip out the LWJGL3 ARM32 and ARM64 libraries, since 1.9.11 includes them but can't use them... and they aren't that small. That isn't hard, it's just a step to be aware of.

I'll probably put off updating within gdx-liftoff until another major libGDX version, but I can update the gdx-lml version projects can depend on by default,

@tommyettinger
Copy link

Also, some of the JARs in that Sonatype snapshots link are nearly empty, like:

Filename                                      Date                              File Size (bytes)
gdx-lml-1.9.1.9.11-20200822.172945-2.jar      Sat Aug 22 17:29:45 UTC 2020      261

@czyzby
Copy link
Owner

czyzby commented Aug 22, 2020

Right, the first upload is correct, but something seems to override it. I think I've had this issue before and it all comes down to weird Gradle setup that this project has. I've reuploaded a couple libraries 1 by 1, it should be fixed now.

@metaphore
Copy link
Contributor Author

Thanks, @czyzby, it appears that the artifact is fixed now.

@metaphore metaphore deleted the gdx-1.9.11 branch May 15, 2022 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants