Skip to content
This repository has been archived by the owner on Jun 22, 2023. It is now read-only.

Update master branch with multiple fixes and features #98

Merged
merged 49 commits into from
Feb 2, 2020
Merged

Update master branch with multiple fixes and features #98

merged 49 commits into from
Feb 2, 2020

Conversation

d-Rickyy-b
Copy link
Owner

Apart from several fixes, there are also a lot of old features I never merged into master. This branch currently lools like it needs some more attention to it.

@d-Rickyy-b
FIX: Remove debug sysout
417570e
@d-Rickyy-b
TASK: Update versionCode to 29
264fe8c
@d-Rickyy-b
TASK: Add new strings for new notifications
4a4c746
@d-Rickyy-b
FIX: Rename "titel" to "title"
7fc1632 
Well... german, english, who cares?
@d-Rickyy-b
TASK: Rename "zeile" to "row"
17375a5
@d-Rickyy-b
FEATURE: Method to notify changes on a TimeTableDay
fa9adb6
@d-Rickyy-b
TASK: New constructor for TimeTableDay
29d3d10 
To create a ttd from an existing ttd
@d-Rickyy-b
TASK: Method to get notificationtitle from ttd
ef1493b
@d-Rickyy-b
TASK: Add method to get notificationticker from ttd
f957834
@d-Rickyy-b
TASK: Add method to get notificationText from ttd
7f65d3b
@d-Rickyy-b
FEATURE: Implement detailed notifications
277c9dd 
fixes #51 #50
@d-Rickyy-b
TASK: Add strings for notification/logging settings
6c4dfd2
@d-Rickyy-b
TASK: Detail notification switchpreference
f149f7f
@d-Rickyy-b
TASK: Update version
17e431c
@d-Rickyy-b
TASK: Add SwitchPreference for file logging
f8a326a 
This must be hidden somewhere from the user!
@d-Rickyy-b
TASK: Refactor class_name to className
9a84885
@d-Rickyy-b
TASK: Refactor variable names
361987f
@d-Rickyy-b
FIX: Rename class_name to className
04ec2fb
@d-Rickyy-b
TASK: Add Javadoc to TimeTableElement
a77b596
@d-Rickyy-b
TASK: Reformat if else code
2f9173e 
It was unnecessary to use the else, since we are returning if we execute the if part
@d-Rickyy-b
FIX: Add missing replace command
0036a5a
@d-Rickyy-b
TASK: More javadoc
d3e5385
@d-Rickyy-b
TASK: Remove SuppressLint import
b393512
@d-Rickyy-b
TASK: Use default Locale
10ddf82
@d-Rickyy-b
FIX: Don't use build in travis script, rather use assembleRelease
7743d5d
@d-Rickyy-b
FIX: Travis locale
976f447 
The build failed since the tests were checking for a string obtained from the german locale
@d-Rickyy-b
FIX: Another try to fix missing locale
7e290d9
@d-Rickyy-b
FIX: Next try to clean up locale
bcf0414
@d-Rickyy-b
TASK: Update gradle
0a1346e
@d-Rickyy-b
FEATURE: Add "active" propertie to TTE
74c33fb
philippstappert
philippstappert previously approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@philippstappert philippstappert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@coveralls
Copy link

coveralls commented Oct 3, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 306

  • 58 of 100 (58.0%) changed or added relevant lines in 8 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+3.0%) to 21.265%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/src/main/java/de/aurora/mggvertretungsplan/parsing/MockParser.java 0 1 0.0%
app/src/main/java/de/aurora/mggvertretungsplan/datamodel/TimeTable.java 5 7 71.43%
app/src/main/java/de/aurora/mggvertretungsplan/datamodel/TimeTableDay.java 34 36 94.44%
app/src/main/java/de/aurora/mggvertretungsplan/datamodel/TimeTableElement.java 18 24 75.0%
app/src/main/java/de/aurora/mggvertretungsplan/util/NotificationHelper.java 0 8 0.0%
app/src/main/java/de/aurora/mggvertretungsplan/util/Logger.java 0 9 0.0%
app/src/main/java/de/aurora/mggvertretungsplan/services/DownloadTimeTableWorker.java 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
app/src/main/java/de/aurora/mggvertretungsplan/services/DownloadTimeTableWorker.java 1 0%
app/src/main/java/de/aurora/mggvertretungsplan/util/Logger.java 2 0%
Totals Coverage Status
Change from base Build 295: 3.0%
Covered Lines: 306
Relevant Lines: 1439
💛 - Coveralls

@d-Rickyy-b d-Rickyy-b merged commit 2967004 into master Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@philippstappert philippstappert philippstappert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-Rickyy-b @coveralls @philippstappert