Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: Paste data object class #137

Merged
merged 2 commits into from
Oct 9, 2019
Merged

REFACTOR: Paste data object class #137

merged 2 commits into from
Oct 9, 2019

Conversation

raymonshansen
Copy link
Contributor

Delegate to built-in magic methods where available to simplify code.

@raymonshansen
REFACTOR: Paste data object class
24e2f21 
delegate to built in magic methods where available to simplify code.
@coveralls
Copy link

coveralls commented Oct 8, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 208

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 68.014%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pastepwn/core/paste.py 3 4 75.0%
Totals Coverage Status
Change from base Build 184: 1.2%
Covered Lines: 1346
Relevant Lines: 1979
💛 - Coveralls

d-Rickyy-b
d-Rickyy-b requested changes Oct 8, 2019
View reviewed changes
Copy link
Owner

@d-Rickyy-b d-Rickyy-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the one thing in the set_body method? Thank you a lot!

pastepwn/core/paste.py Show resolved Hide resolved
pastepwn/core/paste.py Show resolved Hide resolved
pastepwn/core/paste.py Show resolved Hide resolved
@MaxJohansen @raymonshansen
Update paste.py
e4eb2d2 
Guard against stringifying 'None', 'False'
Repository owner deleted a comment Oct 9, 2019
@d-Rickyy-b d-Rickyy-b merged commit be7ea9b into d-Rickyy-b:master Oct 9, 2019
@raymonshansen raymonshansen deleted the patch-1 branch October 9, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-Rickyy-b d-Rickyy-b d-Rickyy-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raymonshansen @coveralls @d-Rickyy-b @MaxJohansen