Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis config #152

Merged
merged 5 commits into from
Oct 18, 2019
Merged

Conversation

wescran
Copy link
Contributor

@wescran wescran commented Oct 15, 2019

Added test in after_success command to check for correct python version. This provides only one coverage report for the build. Solves #144

@coveralls
Copy link

Pull Request Test Coverage Report for Build 243

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.8%) to 73.469%

Totals Coverage Status
Change from base Build 239: -1.8%
Covered Lines: 1800
Relevant Lines: 2450

💛 - Coveralls

@wescran
Copy link
Contributor Author

wescran commented Oct 18, 2019

@d-Rickyy-b Is there anything I need to revise to pass the coveralls check?

@d-Rickyy-b
Copy link
Owner

@wescran Hi there, you can safely ignore the coveralls check. It's just a metric for me to measure test coverage. I don't care much about it, it's just good to know where you are lacking unit tests.

I did not find the time yet to review the changes made, I will check it this weekend (maybe tonight). Sorry it takes me so long 🙈.

@d-Rickyy-b d-Rickyy-b merged commit 8b78c98 into d-Rickyy-b:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants